Improve error for when instance lock is already locked #33788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndersonQ
added
enhancement
8.7-candidate
backport-v8.5.0
AndersonQ
requested review from
belimawr and
rdner
and removed request for
a team
botelastic
bot
added
the
needs_team
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
botelastic
bot
removed
the
needs_team
belimawr
approved these changes
Nov 23, 2022
libbeat/cmd/instance/locks/lock.go
Outdated
| @@ -111,8 +111,9 @@ func (lock *Locker) Lock() error { | |||
| } | |||
| // case: lock could not be obtained. | |||
| if !isLocked { | |||
|
|
|||
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
cmacknz
reviewed
Nov 23, 2022
changelog/fragments/1669212543-improve-error-for-when-instance-lock-is-already-locked.yaml
Outdated
Show resolved
Hide resolved
cmacknz
approved these changes
Nov 23, 2022
|
/test |
|
/test |
mergify bot
pushed a commit
that referenced
this pull request
Nov 30, 2022
(cherry picked from commit 451f75b)
mergify bot
pushed a commit
that referenced
this pull request
Nov 30, 2022
(cherry picked from commit 451f75b)
AndersonQ
added a commit
that referenced
this pull request
Dec 1, 2022
AndersonQ
added a commit
that referenced
this pull request
Dec 2, 2022
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improves the error message for when the instance lock is already locked by adding the lock path on the message.
Why is it important?
It makes understanding the error easier as it'll state exactly what is locked.
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Have 2 filebeats running using the same
path.data, the second should show the error that this PR improveRelated issues
Logs
Original log: