Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up with changelog for 3338 #3363

Merged
merged 1 commit into from
Jan 13, 2017
Merged

Follow up with changelog for 3338 #3363

merged 1 commit into from
Jan 13, 2017

Conversation

tsg
Copy link
Contributor

@tsg tsg commented Jan 13, 2017

No description provided.

@tsg tsg added needs_backport PR is waiting to be backported to other branches. review labels Jan 13, 2017
@ruflin ruflin merged commit 03b70c3 into elastic:master Jan 13, 2017
tsg added a commit to tsg/beats that referenced this pull request Jan 13, 2017
@tsg tsg removed the needs_backport PR is waiting to be backported to other branches. label Jan 13, 2017
ruflin pushed a commit that referenced this pull request Jan 13, 2017
* Ensure harvesterCounter 8-byte alignment (#3273) (#3338)

harvesterCounter is accessed atomically and will fault on x86-32 or ARM
if not 8-byte aligned. See golang/go#599 for more details on why it
fails and https://golang.org/pkg/sync/atomic/#pkg-note-BUG for how
putting the field first in the struct fixes it.
(cherry picked from commit fd64af2)

* Follow up with changelog for 3338 (#3363)

(cherry picked from commit 03b70c3)
@spacewrangler
Copy link
Contributor

Thanks @tsg for merging my fix. Just submitted a PR #3371 with a typo correction for the comments added for this.

leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
* Ensure harvesterCounter 8-byte alignment (elastic#3273) (elastic#3338)

harvesterCounter is accessed atomically and will fault on x86-32 or ARM
if not 8-byte aligned. See golang/go#599 for more details on why it
fails and https://golang.org/pkg/sync/atomic/#pkg-note-BUG for how
putting the field first in the struct fixes it.
(cherry picked from commit f6f5e10)

* Follow up with changelog for 3338 (elastic#3363)

(cherry picked from commit 6af51cd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants