Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-pack/filebeat/input/httpjson: fix handling of array of string/array #33609

Merged
merged 1 commit into from
Nov 10, 2022
Merged

x-pack/filebeat/input/httpjson: fix handling of array of string/array #33609

merged 1 commit into from
Nov 10, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Nov 8, 2022 •
edited
Loading

What does this PR do?

This is an alternative proposal for #30368, it adds support for splitting arrays of arrays and arrays of strings. It takes the tests written by @legoguy1000 from #30368 with minor modification.

Why is it important?

This is a requested feature from a number of users, see #30345, and the behaviour appears from the documentation to be allowed.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added bug Filebeat Filebeat Team:Security-External Integrations backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.5.0 Automated backport with mergify 8.6 candidate labels Nov 8, 2022
@efd6 efd6 self-assigned this Nov 8, 2022
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 8, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 8, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-08T20:49:07.480+0000

  • Duration: 71 min 37 sec

Test stats 🧪

Test Results
Failed 0
Passed 2319
Skipped 167
Total 2486

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 marked this pull request as ready for review November 8, 2022 03:42
@efd6 efd6 requested a review from a team as a code owner November 8, 2022 03:42
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@mergify
Copy link
Contributor

mergify bot commented Nov 8, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 30345-httpjson upstream/30345-httpjson
git merge upstream/main
git push upstream 30345-httpjson

@efd6 @legoguy1000
x-pack/filebeat/input/httpjson: fix handling of array of string/array
c6d060d 
Co-authored-by: Alex Resnick <adr8292@gmail.com>
@efd6 efd6 merged commit c348a31 into elastic:main Nov 10, 2022
mergify bot pushed a commit that referenced this pull request Nov 10, 2022
@efd6 @mergify
x-pack/filebeat/input/httpjson: fix handling of split on array of str…
51de6f8 
…ing/array (#33609)

This enables splitting of arrays of arrays and arrays of string in the same
way that splitting on maps currently works.

Co-authored-by: Alex Resnick <adr8292@gmail.com>
(cherry picked from commit c348a31)

# Conflicts:
#	x-pack/filebeat/input/httpjson/split.go
#	x-pack/filebeat/input/httpjson/split_test.go
@mergify mergify bot mentioned this pull request Nov 10, 2022
Closed
mergify bot pushed a commit that referenced this pull request Nov 10, 2022
@efd6 @mergify
x-pack/filebeat/input/httpjson: fix handling of split on array of str…
9ed6269 
…ing/array (#33609)

This enables splitting of arrays of arrays and arrays of string in the same
way that splitting on maps currently works.

Co-authored-by: Alex Resnick <adr8292@gmail.com>
(cherry picked from commit c348a31)
@mergify mergify bot mentioned this pull request Nov 10, 2022
Merged
efd6 added a commit that referenced this pull request Nov 10, 2022
@mergify @efd6
x-pack/filebeat/input/httpjson: fix handling of split on array of str…
ed600cd 
…ing/array (#33609) (#33639)

This enables splitting of arrays of arrays and arrays of string in the same
way that splitting on maps currently works.

Co-authored-by: Alex Resnick <adr8292@gmail.com>
(cherry picked from commit c348a31)

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@efd6 @legoguy1000 @chrisberkhout
x-pack/filebeat/input/httpjson: fix handling of split on array of str…
16a128e 
…ing/array (#33609)

This enables splitting of arrays of arrays and arrays of string in the same
way that splitting on maps currently works.

Co-authored-by: Alex Resnick <adr8292@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShourieG ShourieG ShourieG approved these changes

Assignees

@efd6 efd6

Labels
8.6 candidate backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.5.0 Automated backport with mergify bug Filebeat Filebeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filebeat httpjson input response.split fails on an array of arrays
3 participants
@efd6 @elasticmachine @ShourieG