Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Heartbeat] states.duration_ms should be a long not a date #33563

Merged
merged 3 commits into from
Nov 3, 2022
Merged

[Heartbeat] states.duration_ms should be a long not a date #33563

merged 3 commits into from
Nov 3, 2022

Conversation

andrewvc
Copy link
Contributor

@andrewvc andrewvc commented Nov 2, 2022 •
edited
Loading

This bug snuck in somehow, breaking indexing

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@andrewvc
[Heartbeat] states.duration_ms should be a long not a date
69b342d 
This bug snuck in somehow, breaking indexing
@andrewvc andrewvc requested a review from a team as a code owner November 2, 2022 20:19
@andrewvc andrewvc self-assigned this Nov 2, 2022
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 2, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2022

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @andrewvc? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

emilioalvap
emilioalvap approved these changes Nov 2, 2022
View reviewed changes
Copy link
Collaborator

@emilioalvap emilioalvap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending mage update

@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 2, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-03T00:42:37.172+0000

  • Duration: 52 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 1889
Skipped 25
Total 1914

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@andrewvc andrewvc added backport-v8.5.0 Automated backport with mergify Team:obs-ds-hosted-services Label for the Observability Hosted Services team labels Nov 3, 2022
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 3, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

vigneshshanmugam
vigneshshanmugam approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewvc andrewvc merged commit 82cb594 into elastic:main Nov 3, 2022
@andrewvc andrewvc deleted the fix-type-of-states-duration branch November 3, 2022 12:40
mergify bot pushed a commit that referenced this pull request Nov 3, 2022
@andrewvc @mergify
[Heartbeat] states.duration_ms should be a long not a date (#33563)
ed56480 
* [Heartbeat] states.duration_ms should be a long not a date

This bug snuck in somehow, breaking indexing

* Changelog

* Mage update

(cherry picked from commit 82cb594)
@mergify mergify bot mentioned this pull request Nov 3, 2022
Merged
andrewvc added a commit that referenced this pull request Nov 3, 2022
@mergify @andrewvc
[Heartbeat] states.duration_ms should be a long not a date (#33563) (#…
41e5e0c 
…33573)

* [Heartbeat] states.duration_ms should be a long not a date

This bug snuck in somehow, breaking indexing

* Changelog

* Mage update

(cherry picked from commit 82cb594)

Co-authored-by: Andrew Cholakian <andrewvc@elastic.co>
@shahzad31
Copy link
Contributor

POST FF Testing looks good
image

chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@andrewvc @chrisberkhout
[Heartbeat] states.duration_ms should be a long not a date (#33563)
68aa2c8 
* [Heartbeat] states.duration_ms should be a long not a date

This bug snuck in somehow, breaking indexing

* Changelog

* Mage update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilioalvap emilioalvap emilioalvap approved these changes

@vigneshshanmugam vigneshshanmugam vigneshshanmugam approved these changes

Assignees

@andrewvc andrewvc

Labels
backport-v8.5.0 Automated backport with mergify bug Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.5.1 v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrewvc @elasticmachine @shahzad31 @vigneshshanmugam @emilioalvap