-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove incorrect ES field #33263
Remove incorrect ES field #33263
Conversation
Removes elasticsearch.node_stats.indices.bulk.avg_time.bytes The field doesn't exist in https://github.com/klacabane/elasticsearch/blob/fede65858555e4106027b7498f6dfda85df87c8e/x-pack/plugin/core/src/main/resources/monitoring-es-mb.json and also doesn't make sense that we'd have bytes under a time grouping.
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
This pull request is now in conflicts. Could you fix it? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
* Remove incorrect ES field Removes elasticsearch.node_stats.indices.bulk.avg_time.bytes The field doesn't exist in https://github.com/klacabane/elasticsearch/blob/fede65858555e4106027b7498f6dfda85df87c8e/x-pack/plugin/core/src/main/resources/monitoring-es-mb.json and also doesn't make sense that we'd have bytes under a time grouping. * Changelog entry * More whitespace fiddling (cherry picked from commit 1032646) # Conflicts: # metricbeat/module/elasticsearch/fields.go
* Remove incorrect ES field (#33263) * Remove incorrect ES field Removes elasticsearch.node_stats.indices.bulk.avg_time.bytes The field doesn't exist in https://github.com/klacabane/elasticsearch/blob/fede65858555e4106027b7498f6dfda85df87c8e/x-pack/plugin/core/src/main/resources/monitoring-es-mb.json and also doesn't make sense that we'd have bytes under a time grouping. * Changelog entry * More whitespace fiddling (cherry picked from commit 1032646) # Conflicts: # metricbeat/module/elasticsearch/fields.go * metricbeat: make update Co-authored-by: Mat Schaffer <mat@elastic.co>
* Remove incorrect ES field Removes elasticsearch.node_stats.indices.bulk.avg_time.bytes The field doesn't exist in https://github.com/klacabane/elasticsearch/blob/fede65858555e4106027b7498f6dfda85df87c8e/x-pack/plugin/core/src/main/resources/monitoring-es-mb.json and also doesn't make sense that we'd have bytes under a time grouping. * Changelog entry * More whitespace fiddling
What does this PR do?
Removes elasticsearch.node_stats.indices.bulk.avg_time.bytes
Why is it important?
The field doesn't exist in https://github.com/klacabane/elasticsearch/blob/fede65858555e4106027b7498f6dfda85df87c8e/x-pack/plugin/core/src/main/resources/monitoring-es-mb.json, isn't populated by the module code, also doesn't make sense that we'd have bytes under a time grouping.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
Set up from-source monitoring
Run the Elasticsearch module in default mode
Note lack of
elasticsearch > node > stats > indices > bulk > avg_time > bytes
in mappings.Related issues
Closes #33211
Use cases
Using the elasticsearch metricbeat module to monitor elasticsearch in non-xpack mode.