Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filebeat/module/fortinet: import dashboard from fortigate integration #33003

Merged
merged 5 commits into from
Sep 13, 2022
Merged

filebeat/module/fortinet: import dashboard from fortigate integration #33003

merged 5 commits into from
Sep 13, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Sep 7, 2022

What does this PR do?

This adds a dashboard for the Fortinet Firewall module imported from the fortinet_fortigate integration.

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added enhancement Filebeat Filebeat Team:Security-External Integrations backport-skip Skip notification from the automated backport with mergify 8.5 candidate labels Sep 7, 2022
@efd6 efd6 self-assigned this Sep 7, 2022
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 7, 2022
@efd6 efd6 force-pushed the 19810-fortinet_firewall branch from 79fccf0 to da7814e Compare September 7, 2022 07:41
@efd6 efd6 marked this pull request as ready for review September 7, 2022 08:47
@efd6 efd6 requested a review from a team as a code owner September 7, 2022 08:47
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-07T07:41:34.647+0000

  • Duration: 72 min 28 sec

Test stats 🧪

Test Results
Failed 0
Passed 2237
Skipped 166
Total 2403

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

andrewkroh
andrewkroh approved these changes Sep 7, 2022
View reviewed changes
CHANGELOG.next.asciidoc
@@ -20,7 +20,8 @@ https://github.com/elastic/beats/compare/v8.2.0\...main[Check the HEAD diff]


*Filebeat*
- [Httpjson]- Fix for pagination at root level not working when used with chaining.
- [Httpjson]- Fix for pagination at root level not working when used with chaining.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a newline separating Filebeat section and bulleted list? The github preview does not render as I would expect, but I'm not sure if that affects our website.

Copy link
Contributor Author

@efd6 efd6 Sep 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably wants more than that. Propose

Suggested change
- [Httpjson]- Fix for pagination at root level not working when used with chaining.
- Fix HTTP JSON pagination at root level when used with chaining. {issue}32618[32618] {pull}32722[32722]

Copy link
Member

@andrewkroh andrewkroh Sep 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That proposal looks good.

@efd6 efd6 requested a review from andrewkroh September 12, 2022 22:21
@efd6 efd6 merged commit fa5047c into elastic:main Sep 13, 2022
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@efd6 @chrisberkhout
filebeat/module/fortinet: import dashboard from fortigate integration (…
4f05b4e 
…#33003)

Used clonedash to construct new identifiers and then exported dashboard
with filebeat export.

Then perform the following operations:
* adjust dataset query: data_stream.dataset:fortinet_fortigate.log => event.dataset:fortinet.firewall
* adjust index patters: log-* => filebeat-*
* adjust title
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh Awaiting requested review from andrewkroh

Assignees

@efd6 efd6

Labels
8.5 candidate backport-skip Skip notification from the automated backport with mergify enhancement Filebeat Filebeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efd6 @elasticmachine @andrewkroh