-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packetbeat/sniffer: allow multiple interface devices to be followed #32933
Conversation
This pull request is now in conflicts. Could you fix it? 🙏
|
b38350d
to
ccf510d
Compare
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
e5824c4
to
4d7dab6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (I reviewed the last commit 4d7dab6e8213a68ffc507dfe9c66b4b568b5ef48. I left other comments relating to the parent commits in #32732).
} | ||
if defaultRoute == nil { | ||
return s.sniffStatic(s.device) | ||
g, ctx := errgroup.WithContext(context.Background()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the sniffer also utilizing the done
channel as a shutdown signal, I would consider a future refactoring to combine the shutdown signalling into a single context.Context
. Like having a ctx that comes down from the beater package that gets cancelled on shutdown and then pass that into this errgroup as its parent.
If this is OK to merge, please also approve the parent PR; I'd like to keep these separate in the history. |
This pull request is now in conflicts. Could you fix it? 🙏
|
This runs multiple sniffers for each Sniffer, each handling default route polling as needed independently. All sniffers terminate if any individual terminates.
4d7dab6
to
dda0ba3
Compare
…32933) This runs multiple sniffers for each Sniffer, each handling default route polling as needed independently. All sniffers terminate if any individual terminates.
What does this PR do?
This runs multiple sniffers for each Sniffer, each handling default route
polling as needed independently. All sniffers terminate if any
individual terminates.
Why is it important?
This allows multiple network devices to be followed.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs