Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AWS docs to clarify tag filtering configuration #32435

Merged
merged 2 commits into from
Jul 25, 2022
Merged

Update AWS docs to clarify tag filtering configuration #32435

merged 2 commits into from
Jul 25, 2022

Conversation

tommyers-elastic
Copy link
Contributor

What does this PR do?

Update AWS docs to clarify tag filtering configuration

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

#32358
#32408

@tommyers-elastic tommyers-elastic requested a review from a team as a code owner July 21, 2022 11:23
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 21, 2022
@tommyers-elastic tommyers-elastic mentioned this pull request Jul 21, 2022
Merged
6 tasks
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 21, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-21T12:58:15.571+0000

  • Duration: 20 min 10 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@tommyers-elastic tommyers-elastic force-pushed the update-docs-on-aws-cloudwatch-tagging branch from 97bddd7 to bd28846 Compare July 21, 2022 11:43
@tommyers-elastic tommyers-elastic added the Team:Cloud-Monitoring Label for the Cloud Monitoring team label Jul 21, 2022
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 21, 2022
sayden
sayden approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tommyers-elastic tommyers-elastic merged commit 96f67e8 into elastic:main Jul 25, 2022
@tommyers-elastic tommyers-elastic deleted the update-docs-on-aws-cloudwatch-tagging branch July 25, 2022 09:31
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@tommyers-elastic @chrisberkhout
Update AWS docs to clarify tag filtering configuration (#32435)
f3c67bf 
* update docs to clarify tag filtering configuration

* commit the results of 'make update'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayden sayden sayden approved these changes

@kaiyan-sheng kaiyan-sheng Awaiting requested review from kaiyan-sheng

Assignees

@tommyers-elastic tommyers-elastic

Labels
Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tommyers-elastic @elasticmachine @sayden