-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] httpjson: Add replaceAll helper function #32365
Merged
andrewkroh
merged 3 commits into
elastic:main
from
andrewkroh:feature/fb/httpjson-replaceAll-func
Jul 19, 2022
Merged
[Filebeat] httpjson: Add replaceAll helper function #32365
andrewkroh
merged 3 commits into
elastic:main
from
andrewkroh:feature/fb/httpjson-replaceAll-func
Jul 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
added
enhancement
Filebeat
Filebeat
Team:Security-External Integrations
labels
Jul 14, 2022
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Jul 14, 2022
replaceAll returns a copy of the string s with all non-overlapping instances of old replaced by new. Note that the order of the arguments differs from Go's [strings.ReplaceAll] to make pipelining more ergonomic. This allows s to be piped in because it is the final argument. For example, [[ "some value" | replaceAll "some" "my" ]] // == "my value"
andrewkroh
force-pushed
the
feature/fb/httpjson-replaceAll-func
branch
from
July 14, 2022 23:25
c3fd0e6
to
a740f93
Compare
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Collaborator
efd6
approved these changes
Jul 15, 2022
vinit-chauhan
approved these changes
Jul 19, 2022
vinit-chauhan
approved these changes
Jul 19, 2022
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
* sort helper functions * httpjson: Add replaceAll helper function replaceAll returns a copy of the string s with all non-overlapping instances of old replaced by new. Note that the order of the arguments differs from Go's [strings.ReplaceAll] to make pipelining more ergonomic. This allows s to be piped in because it is the final argument. For example, [[ "some value" | replaceAll "some" "my" ]] // == "my value"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
replaceAll
returns a copy of the string s with all non-overlapping instancesof old replaced by new.
Note that the order of the arguments differs from Go's
strings.ReplaceAll
tomake pipelining more ergonomic. This allows s to be piped in because it is
the final argument. For example,
Why is it important?
This gives a simple way to manipulate a string in a template. The use case is fixing an incorrectly formatted nextlink value that an API (Trend Micro Vision One) is returning for pagination.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues