-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AWS Fargate] Added support for DesiredStatus and KnownStatus for ECS Tasks #32342
Conversation
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I added a few comments for a couple of nonblocking aspects.
@@ -148,15 +150,6 @@ | |||
}, | |||
"name": "query-metadata" | |||
}, | |||
"event": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are those two fields no longer present in the data.json
file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed the same but could not find the exact cause. That files was generated by executing go test -data -tags=integration
inside task_stats
What does this PR do?
This PR adds DesiredStatus and KnownStatus among the collected metrics for ECS Fargate. The values are collected at the task level, not at the container level. More info at: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task-metadata-endpoint-v4.html
This PR also includes some minor refactoring and fixes for
golangci-lint
related errors that were present prior to this change.Why is it important?
See #32077
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
Inside
x-pack/metricbeat/module/awsfargate/task_stats
go test
to execute unit testsgo test -tags=integration
to execute integration testsTo test the end-to-end data flow, the easiest approach would be running amazon-ecs-local-container-endpoints and metricbeat in two Docker containers on the same network (more info available at this blog post from AWS)
Related issues