Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename queue.Batch.ACK -> queue.Batch.Done #31903

Merged
merged 2 commits into from
Jun 13, 2022
Merged

rename queue.Batch.ACK -> queue.Batch.Done #31903

merged 2 commits into from
Jun 13, 2022

Conversation

faec
Copy link
Contributor

@faec faec commented Jun 9, 2022

What does this PR do?

Rename the ACK function in the queue.Batch interface to Done. This function is the only way to finish handling a batch, and must be called regardless of whether the events were acked or not. Its only effect is to inform the queue that the events can be discarded (and to trigger any associated callbacks).

queue.Batch.ACK is used in the vicinity of actual ACK handling, which can make it confusing to follow the side effects of various similarly-named functions. Done more clearly separates ACK handling from general event cleanup.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@faec faec added cleanup Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Jun 9, 2022
@faec faec self-assigned this Jun 9, 2022
@faec faec requested a review from a team as a code owner June 9, 2022 21:04
@faec faec requested review from cmacknz and kvch and removed request for a team June 9, 2022 21:04
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 9, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 9, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-09T21:13:17.547+0000

  • Duration: 75 min 26 sec

Test stats 🧪

Test Results
Failed 0
Passed 22229
Skipped 1935
Total 24164

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@faec faec merged commit 10b6c20 into elastic:main Jun 13, 2022
@faec faec deleted the batch-ack branch June 13, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants