Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HealthyHostCount and UnHealthyHostCount for application ELB #31853

Merged
merged 3 commits into from
Jun 8, 2022
Merged

Add HealthyHostCount and UnHealthyHostCount for application ELB #31853

merged 3 commits into from
Jun 8, 2022

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Jun 7, 2022 •
edited
Loading

What does this PR do?

This PR is to add HealthyHostCount and UnHealthyHostCount for application ELB from CloudWatch.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner June 7, 2022 18:38
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 7, 2022
@kaiyan-sheng kaiyan-sheng self-assigned this Jun 7, 2022
@kaiyan-sheng kaiyan-sheng added backport-v8.3.0 Automated backport with mergify backport-7.17 Automated backport to the 7.17 branch with mergify Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Jun 7, 2022
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 7, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 7, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-08T18:06:54.767+0000

  • Duration: 99 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 3895
Skipped 1008
Total 4903

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@aspacca
Copy link

aspacca commented Jun 8, 2022

minor: should we regenerate the sample json data?

@kaiyan-sheng kaiyan-sheng merged commit 54597d2 into elastic:main Jun 8, 2022
@kaiyan-sheng kaiyan-sheng deleted the aws_elb branch June 8, 2022 20:00
mergify bot pushed a commit that referenced this pull request Jun 8, 2022
@kaiyan-sheng @mergify
Add HealthyHostCount and UnHealthyHostCount for application ELB (#31853)
41d0a5a 
(cherry picked from commit 54597d2)

# Conflicts:
#	x-pack/metricbeat/module/aws/fields.go
@mergify mergify bot mentioned this pull request Jun 8, 2022
Merged
mergify bot pushed a commit that referenced this pull request Jun 8, 2022
@kaiyan-sheng @mergify
Add HealthyHostCount and UnHealthyHostCount for application ELB (#31853)
d5d35a6 
(cherry picked from commit 54597d2)
@mergify mergify bot mentioned this pull request Jun 8, 2022
Merged
kaiyan-sheng added a commit that referenced this pull request Jun 9, 2022
@mergify @kaiyan-sheng
Add HealthyHostCount and UnHealthyHostCount for application ELB (#31853…
08a5458 
…) (#31874)

(cherry picked from commit 54597d2)

Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
kaiyan-sheng added a commit that referenced this pull request Jun 9, 2022
@mergify @kaiyan-sheng
[7.17](backport #31853) Add HealthyHostCount and UnHealthyHostCount f…
d0a4f89 
…or application ELB (#31873)

(cherry picked from commit 54597d2)

Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@kaiyan-sheng @chrisberkhout
Add HealthyHostCount and UnHealthyHostCount for application ELB (#31853)
0e9d3e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aspacca aspacca aspacca approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.3.0 Automated backport with mergify Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UnHealthyHostCount metrics for AWS ALB
3 participants
@kaiyan-sheng @elasticmachine @aspacca