Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auditbeat: update import of github.com/elastic/go-libaudit #31710

Merged
merged 2 commits into from
May 23, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented May 23, 2022

What does this PR do?

This updates the import of github.com/elastic/go-libaudit to pick up a fix for a but that is affecting auditbeat on GKE.

Why is it important?

The bug breaks use on older linux platforms.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added bug Auditbeat Team:Security-External Integrations backport-skip Skip notification from the automated backport with mergify 8.3-candidate labels May 23, 2022
@efd6 efd6 requested review from andrewkroh, adriansr and a team May 23, 2022 12:28
@efd6 efd6 requested a review from a team as a code owner May 23, 2022 12:28
@efd6 efd6 self-assigned this May 23, 2022
@efd6 efd6 requested review from belimawr and faec and removed request for a team May 23, 2022 12:28
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 23, 2022
CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@adriansr adriansr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Collaborator

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6
Copy link
Contributor Author

efd6 commented May 23, 2022

/test

@andrewkroh
Copy link
Member

andrewkroh commented May 23, 2022

The e2e failure appears to be unrelated. Additionally e2e tests appear to be failing on main. So I think it is safe to say this is unrelated and merge it.

[2022-05-23T15:10:12.696Z] --- Failed steps:
[2022-05-23T15:10:12.696Z] 
[2022-05-23T15:10:12.696Z]   Scenario: The APM Server chart will create recommended K8S resources # features/apm_server.feature:5
[2022-05-23T15:10:12.696Z]     Given a cluster is running # features/apm_server.feature:6
[2022-05-23T15:10:12.696Z]       Error: the cluster is not running
[2022-05-23T15:10:12.696Z] 
[2022-05-23T15:10:12.696Z] 
[2022-05-23T15:10:12.696Z] 1 scenarios (1 failed)
[2022-05-23T15:10:12.696Z] 11 steps (1 failed, 10 skipped)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.3-candidate Auditbeat backport-skip Skip notification from the automated backport with mergify bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auditbeat 8.3.0-SNAPSHOT is failing on GKE: "failed to get audit status"
4 participants