Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-pack/filebeat/module/rabbitmq: add handling of authentication data #31680

Merged
merged 3 commits into from
Jun 16, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented May 19, 2022

What does this PR do?

This adds access/authentication-related fields to RabbitMQ documents.

Why is it important?

These can be useful in a security context.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added enhancement Team:Integrations Label for the Integrations team backport-skip Skip notification from the automated backport with mergify 8.3-candidate labels May 19, 2022
@efd6 efd6 self-assigned this May 19, 2022
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 19, 2022
@efd6 efd6 marked this pull request as ready for review May 19, 2022 07:14
@efd6 efd6 requested a review from a team as a code owner May 19, 2022 07:14
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine
Copy link
Collaborator

elasticmachine commented May 19, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-14T06:24:07.825+0000

  • Duration: 76 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 2124
Skipped 166
Total 2290

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor

mergify bot commented May 20, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 31159-rabbitmq upstream/31159-rabbitmq
git merge upstream/main
git push upstream 31159-rabbitmq

@efd6 efd6 force-pushed the 31159-rabbitmq branch from f709432 to 04dcba4 Compare May 22, 2022 23:08
@mergify
Copy link
Contributor

mergify bot commented May 23, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 31159-rabbitmq upstream/31159-rabbitmq
git merge upstream/main
git push upstream 31159-rabbitmq

@kaiyan-sheng kaiyan-sheng added the Team:Service-Integrations Label for the Service Integrations team label May 23, 2022
@efd6 efd6 added backport-v8.3.0 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels May 24, 2022
@mergify
Copy link
Contributor

mergify bot commented Jun 1, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 31159-rabbitmq upstream/31159-rabbitmq
git merge upstream/main
git push upstream 31159-rabbitmq

@efd6 efd6 added 8.4-candidate and removed 8.3-candidate backport-v8.3.0 Automated backport with mergify labels Jun 14, 2022
@efd6 efd6 requested a review from endorama June 14, 2022 07:22
@kaiyan-sheng kaiyan-sheng requested a review from a team June 16, 2022 12:52
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.4-candidate enhancement Team:Integrations Label for the Integrations team Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filebeat module RabbitMQ - add ECS authentication fields for SIEM
3 participants