Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filebeat] Fix MISP filters documentation #31434

Merged
merged 4 commits into from
Apr 28, 2022
Merged

[Filebeat] Fix MISP filters documentation #31434

merged 4 commits into from
Apr 28, 2022

Conversation

legoguy1000
Copy link
Contributor

@legoguy1000 legoguy1000 commented Apr 27, 2022 •
edited
Loading

What does this PR do?

The documentation for the Threat Intel MISP module shows the var.filters option as a list when it should be a dictionary. See slack thread https://elasticstack.slack.com/archives/CNEDGGJQ3/p1651059526488649.

Why is it important?

Module doesn't work as a list.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@legoguy1000 legoguy1000 requested a review from a team as a code owner April 27, 2022 13:50
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 27, 2022
@botelastic
Copy link

botelastic bot commented Apr 27, 2022

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 27, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-28T16:14:48.302+0000

  • Duration: 19 min 4 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@aspacca
Copy link

aspacca commented Apr 28, 2022

/test

@legoguy1000 legoguy1000 requested a review from a team as a code owner April 28, 2022 14:22
@legoguy1000 legoguy1000 requested review from rdner and leehinman and removed request for a team April 28, 2022 14:22
@mergify
Copy link
Contributor

mergify bot commented Apr 28, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b misp-docs-fix upstream/misp-docs-fix
git merge upstream/main
git push upstream misp-docs-fix

@legoguy1000
Copy link
Contributor Author

looks like everything passed

@rdner rdner merged commit c64ba6c into elastic:main Apr 28, 2022
kush-elastic pushed a commit to kush-elastic/beats that referenced this pull request May 2, 2022
@legoguy1000 @rdner @kush-elastic
[Filebeat] Fix MISP filters documentation (elastic#31434)
5c3959f 
The documentation for the Threat Intel MISP module shows the `var.filters` option as a list when it should be a dictionary. 

Co-authored-by: Denis Rechkunov <denis.rechkunov@elastic.co>
@andrewkroh andrewkroh added the backport-7.17 Automated backport to the 7.17 branch with mergify label Jul 29, 2022
@mergify mergify bot mentioned this pull request Jul 29, 2022
Merged
andrewkroh pushed a commit to andrewkroh/beats that referenced this pull request Jul 29, 2022
@legoguy1000 @andrewkroh
[Filebeat] Fix MISP filters documentation (elastic#31434)
1966c05 
The documentation for the Threat Intel MISP module shows the `var.filters` option as a list when it should be a dictionary.

Co-authored-by: Denis Rechkunov <denis.rechkunov@elastic.co>
(cherry picked from commit c64ba6c)
andrewkroh pushed a commit that referenced this pull request Jul 29, 2022
@mergify
[Filebeat] Fix MISP filters documentation (#31434) (#32552)
4ec0721 
The documentation for the Threat Intel MISP module shows the `var.filters` option as a list when it should be a dictionary.

Co-authored-by: Alex Resnick <adr8292@gmail.com>
Co-authored-by: Denis Rechkunov <denis.rechkunov@elastic.co>

(cherry picked from commit c64ba6c)
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@legoguy1000 @rdner @chrisberkhout
[Filebeat] Fix MISP filters documentation (#31434)
c4a68ae 
The documentation for the Threat Intel MISP module shows the `var.filters` option as a list when it should be a dictionary. 

Co-authored-by: Denis Rechkunov <denis.rechkunov@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdner rdner rdner approved these changes

@aspacca aspacca aspacca approved these changes

@leehinman leehinman Awaiting requested review from leehinman leehinman was automatically assigned from elastic/elastic-agent-data-plane

Assignees

@legoguy1000 legoguy1000

Labels
backport-7.17 Automated backport to the 7.17 branch with mergify needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@legoguy1000 @elasticmachine @aspacca @rdner @andrewkroh