-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use mapstr.M
instead of common.MapStr
#31420
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
requested review from
rdner and
fearful-symmetry
and removed request for
a team
April 26, 2022 15:04
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Apr 26, 2022
Collaborator
To decrease the amount of changes, the documentation fixes will come in a new PR. |
5 tasks
This pull request is now in conflicts. Could you fix it? 🙏
|
/test |
rdner
approved these changes
Apr 28, 2022
kush-elastic
pushed a commit
to kush-elastic/beats
that referenced
this pull request
May 2, 2022
joshdover
added
the
Team:Elastic-Agent-Data-Plane
Label for the Agent Data Plane team
label
Aug 2, 2022
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Aug 2, 2022
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adopts
mapstr.M
and gets rid ofcommon.MapStr
from libbeat.Why is it important?
We are removing common parts from libbeat in favour of elastic-agent-libs.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.