Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[filebeat] Add a ZIP decoder for httpjson #31304

Merged
merged 5 commits into from
Apr 21, 2022
Merged

[filebeat] Add a ZIP decoder for httpjson #31304

merged 5 commits into from
Apr 21, 2022

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Apr 14, 2022 •
edited
Loading

What does this PR do?

Adds a zip support for httpjson responses.

Why is it important?

Enables support for a wider range of APIs.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@marc-gr marc-gr requested review from a team as code owners April 14, 2022 14:24
@marc-gr marc-gr requested review from kvch and faec and removed request for a team April 14, 2022 14:24
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 14, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 14, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-19T09:58:56.372+0000

  • Duration: 65 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 2066
Skipped 159
Total 2225

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

andrewkroh
andrewkroh reviewed Apr 14, 2022
View reviewed changes
x-pack/filebeat/input/httpjson/encoding_test.go Outdated Show resolved Hide resolved
x-pack/filebeat/input/httpjson/encoding.go Outdated Show resolved Hide resolved
x-pack/filebeat/input/httpjson/encoding_test.go Outdated Show resolved Hide resolved
@mergify
Copy link
Contributor

mergify bot commented Apr 19, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b httpjson-add-zip-decoding upstream/httpjson-add-zip-decoding
git merge upstream/main
git push upstream httpjson-add-zip-decoding

@marc-gr marc-gr requested a review from andrewkroh April 19, 2022 09:57
@marc-gr marc-gr merged commit e41856e into elastic:main Apr 21, 2022
@marc-gr marc-gr deleted the httpjson-add-zip-decoding branch April 21, 2022 14:03
kush-elastic pushed a commit to kush-elastic/beats that referenced this pull request May 2, 2022
@marc-gr @kush-elastic
[filebeat] Add a ZIP decoder for httpjson (elastic#31304)
af25b4c 
* Add a ZIP decoder for httpjson

* Write test file in memory

* Add changelog entry

* Remove wrapper function
@jamiehynds jamiehynds mentioned this pull request May 11, 2022
Closed
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@marc-gr @chrisberkhout
[filebeat] Add a ZIP decoder for httpjson (#31304)
63982cf 
* Add a ZIP decoder for httpjson

* Write test file in memory

* Add changelog entry

* Remove wrapper function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@kvch kvch Awaiting requested review from kvch kvch was automatically assigned from elastic/elastic-agent-data-plane

@faec faec Awaiting requested review from faec faec was automatically assigned from elastic/elastic-agent-data-plane

Assignees

@marc-gr marc-gr

Labels
backport-v8.3.0 Automated backport with mergify enhancement Filebeat Filebeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[httpjson] Add the ability to process zip compressed payloads
3 participants
@marc-gr @elasticmachine @andrewkroh