-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.0](backport #29112) x-pack/packetbeat: install Npcap at start-up when required #30049
Conversation
This add automated installation of an OEM Npcap provided by embedding in the packetbeat executable. The installation is configurable to allow users to retain their own version of Npcap if they have one and to specify the location of the install. To simplify support this configurablity will not be included in the next release, but is comitted here to allow it to be reverted back out to make it easier to add if the decision is made to do that later. (cherry picked from commit 72a43be) # Conflicts: # go.mod
This pull request doesn't have a |
💔 Build Failed
Expand to view the summary
Build stats
Steps errorsExpand to view the steps failures
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be going into 8.1 rather than 8.0, right?
Yes. At the start of the addition it was to be added to 8.0, but I think we missed that boat. It's merged into master, so it will be in 8.1. |
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
This is an automatic backport of pull request #29112 done by Mergify.
Cherry-pick of 72a43be has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com