Correctly fixe how selected packages are defined

[ph]

Fixed creating an empty array way breaking check down the stack.

See

beats/dev-tools/mage/pkg.go

Line 121 in 6b41742

if SelectedPackageTypes != nil {

What does this PR do?

Why is it important?

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

• [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

[elasticmachine]

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

[mergify]

This pull request does not have a backport label. Could you fix it @ph? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

[ph]

/package

[aleksmaus]

Thank you! 👍

[elasticmachine]

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2022-01-26T21:18:25.975+0000

• Duration: 120 min 16 sec

• Commit: ae85071

Test stats 🧪

Test	Results
Failed	1
Passed	47950
Skipped	4284
Total	52235

Test errors

Expand to view the tests failures

Extended / filebeat-windows-8-windows-8 / test_file_no_permission – filebeat.tests.system.test_crawler.Test

Expand to view the error details

 PermissionError: [WinError 5] Access is denied: 'C:\\Users\\jenkins\\workspace\\PR-30039-1-6124aac1-7b2c-4f5a-9e2a-a14ba6fb6be1\\src\\github.com\\elastic\\beats\\filebeat\\build\\system-tests\\run\\test_crawler.Test.test_file_no_permission\\log\\test.log' 

Expand to view the stacktrace

 ..\libbeat\tests\system\beat\beat.py:334: in setUp
    shutil.rmtree(self.working_dir)
C:\Python38\lib\shutil.py:737: in rmtree
    return _rmtree_unsafe(path, onerror)
C:\Python38\lib\shutil.py:610: in _rmtree_unsafe
    _rmtree_unsafe(fullname, onerror)
C:\Python38\lib\shutil.py:615: in _rmtree_unsafe
    onerror(os.unlink, fullname, sys.exc_info())
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

path = 'C:\\Users\\jenkins\\workspace\\PR-30039-1-6124aac1-7b2c-4f5a-9e2a-a14ba6fb6be1\\src\\github.com\\elastic\\beats\\filebeat\\build\\system-tests\\run\\test_crawler.Test.test_file_no_permission\\log'
onerror = <function rmtree.<locals>.onerror at 0x00000036517BBD30>

    def _rmtree_unsafe(path, onerror):
        try:
            with os.scandir(path) as scandir_it:
                entries = list(scandir_it)
        except OSError:
            onerror(os.scandir, path, sys.exc_info())
            entries = []
        for entry in entries:
            fullname = entry.path
            if _rmtree_isdir(entry):
                try:
                    if entry.is_symlink():
                        # This can only happen if someone replaces
                        # a directory with a symlink after the call to
                        # os.scandir or entry.is_dir above.
                        raise OSError("Cannot call rmtree on a symbolic link")
                except OSError:
                    onerror(os.path.islink, fullname, sys.exc_info())
                    continue
                _rmtree_unsafe(fullname, onerror)
            else:
                try:
>                   os.unlink(fullname)
E                   PermissionError: [WinError 5] Access is denied: 'C:\\Users\\jenkins\\workspace\\PR-30039-1-6124aac1-7b2c-4f5a-9e2a-a14ba6fb6be1\\src\\github.com\\elastic\\beats\\filebeat\\build\\system-tests\\run\\test_crawler.Test.test_file_no_permission\\log\\test.log'

C:\Python38\lib\shutil.py:613: PermissionError 

Steps errors

Expand to view the steps failures

Sleep

• Took 0 min 5 sec . View more details here
• Description: 5

filebeat-windows-8-windows-8 - mage build unitTest

• Took 6 min 52 sec . View more details here
• Description: mage build unitTest

filebeat-windows-8-windows-8 - mage build unitTest

• Took 4 min 16 sec . View more details here
• Description: mage build unitTest

filebeat-windows-8-windows-8 - mage build unitTest

• Took 4 min 20 sec . View more details here
• Description: mage build unitTest

gsutil -m -q cp -a public-read test-build-artifacts-filebeat-windows-8-windows-8-tgz gs://beats-ci-t

• Took 0 min 10 sec . View more details here
• Description: @echo off gsutil -m -q cp -a public-read test-build-artifacts-filebeat-windows-8-windows-8-tgz gs://beats-ci-temp/Beats/beats/PR-30039-1

Error signal

• Took 0 min 0 sec . View more details here
• Description: Error 'hudson.AbortException: script returned exit code 1'

🐛 Flaky test report

❕ There are test failures but not known flaky tests.

Expand to view the summary

Genuine test errors

💔 There are test failures but not known flaky tests, most likely a genuine test failure.

• Name: Extended / filebeat-windows-8-windows-8 / test_file_no_permission – filebeat.tests.system.test_crawler.Test

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• /package : Generate the packages and run the E2E tests.

• /beats-tester : Run the installation tests with beats-tester.

• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)