-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dont overwrite metadata in rds and dimension in cloudwatch #29101
Conversation
This pull request does not have a backport label. Could you fix it @aspacca? 🙏
NOTE: |
Pinging @elastic/integrations (Team:Platforms) |
❕ Build Aborted
Expand to view the summary
Build stats
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
Can we add a test around this? Or shouldn't this be found out by the tests already? |
@endorama sure, we can add a test mocking wrong metadata and assuring only the first one will be set |
closing in favour of #29106 |
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
Bug
What does this PR do?
Ensure that dimensions and rds metadata from cloudwatch metric are not overwritten
Why is it important?
It was reported a case of mismatching metadata in RDS metrics between
aws.dimensions.DBInstanceIdentifier
andaws.rds.db_instance.identifier
Changes in this PR will prevent to set the metadata and dimensions multiple time if they are already set for a specific event
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs