Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated coredns fields for 8.0 #28196

Merged
merged 1 commit into from
Oct 1, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.next.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d
- Only filesets that are explicitly configured will be enabled. {issue}17256[17256] {pull}27526[27526]
- All filesets are disabled in the default configuration. {issue}17256[17256] {pull}27762[27762]
- Remove deprecated fields in Kafka module. {pull}27938[27938]
- Remove deprecated fields in coredns module. {pull}28196[28196]

*Heartbeat*

Expand Down
70 changes: 0 additions & 70 deletions filebeat/docs/fields.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -27522,16 +27522,6 @@ coredns fields after normalization



*`coredns.id`*::
+
--
id of the DNS transaction


type: keyword

--

*`coredns.query.size`*::
+
--
Expand All @@ -27544,56 +27534,6 @@ format: bytes

--

*`coredns.query.class`*::
+
--
DNS query class


type: keyword

--

*`coredns.query.name`*::
+
--
DNS query name


type: keyword

--

*`coredns.query.type`*::
+
--
DNS query type


type: keyword

--

*`coredns.response.code`*::
+
--
DNS response code


type: keyword

--

*`coredns.response.flags`*::
+
--
DNS response flags


type: keyword

--

*`coredns.response.size`*::
+
--
Expand All @@ -27606,16 +27546,6 @@ format: bytes

--

*`coredns.dnssec_ok`*::
+
--
dnssec flag


type: boolean

--

[[exported-fields-crowdstrike]]
== Crowdstrike fields

Expand Down
36 changes: 0 additions & 36 deletions x-pack/filebeat/module/coredns/_meta/fields.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,50 +8,14 @@
description: >
coredns fields after normalization
fields:
- name: id
type: keyword
description: >
id of the DNS transaction

- name: query.size
type: integer
format: bytes
description: >
size of the DNS query

- name: query.class
type: keyword
description: >
DNS query class

- name: query.name
type: keyword
description: >
DNS query name

- name: query.type
type: keyword
description: >
DNS query type

- name: response.code
type: keyword
description: >
DNS response code

- name: response.flags
type: keyword
description: >
DNS response flags

- name: response.size
type: integer
format: bytes
description: >
size of the DNS response

- name: dnssec_ok
type: boolean
description: >
dnssec flag

2 changes: 1 addition & 1 deletion x-pack/filebeat/module/coredns/fields.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

29 changes: 1 addition & 28 deletions x-pack/filebeat/module/coredns/log/ingest/pipeline-entry.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,35 +71,8 @@ processors:
- remove:
field:
- coredns.duration
- coredns.dnssec_ok
ignore_missing: true
# The following copies values from dns namespace (ECS) to the coredns
# namespace to avoid introducing breaking change. This should be removed
# for 8.0.0. Additionally coredns.dnssec_ok can be removed.
- set:
field: coredns.id
value: '{{dns.id}}'
ignore_empty_value: true
- set:
field: coredns.query.class
value: '{{dns.question.class}}'
ignore_empty_value: true
- set:
field: coredns.query.name
value: '{{dns.question.name}}'
ignore_empty_value: true
- set:
field: coredns.query.type
value: '{{dns.question.type}}'
ignore_empty_value: true
- set:
field: coredns.response.code
value: '{{dns.response_code}}'
ignore_empty_value: true
- script:
if: ctx.dns?.header_flags != null
lang: painless
source: >
ctx.coredns.response.flags = ctx.dns.header_flags;
# Right trim the trailing dot from domain names.
- script:
if: ctx.dns?.question?.name != null
Expand Down
Original file line number Diff line number Diff line change
@@ -1,18 +1,7 @@
[
{
"@timestamp": "2019-02-12T00:27:28.903Z",
"coredns.dnssec_ok": false,
"coredns.id": "21583",
"coredns.query.class": "IN",
"coredns.query.name": "httpbin.org.cluster.local.",
"coredns.query.size": 43,
"coredns.query.type": "A",
"coredns.response.code": "NXDOMAIN",
"coredns.response.flags": [
"QR",
"RA",
"RD"
],
"coredns.response.size": 136,
"dns.header_flags": [
"QR",
Expand Down Expand Up @@ -64,18 +53,7 @@
},
{
"@timestamp": "2019-03-19T02:57:23.213Z",
"coredns.dnssec_ok": false,
"coredns.id": "6966",
"coredns.query.class": "IN",
"coredns.query.name": "httpbin.org.",
"coredns.query.size": 29,
"coredns.query.type": "A",
"coredns.response.code": "NOERROR",
"coredns.response.flags": [
"QR",
"RA",
"RD"
],
"coredns.response.size": 83,
"dns.header_flags": [
"QR",
Expand Down Expand Up @@ -127,18 +105,7 @@
},
{
"@timestamp": "2019-03-11T07:16:34.013Z",
"coredns.dnssec_ok": false,
"coredns.id": "62762",
"coredns.query.class": "IN",
"coredns.query.name": "czbaoyu.com.",
"coredns.query.size": 29,
"coredns.query.type": "AAAA",
"coredns.response.code": "NOERROR",
"coredns.response.flags": [
"QR",
"RA",
"RD"
],
"coredns.response.size": 100,
"dns.header_flags": [
"QR",
Expand Down
22 changes: 0 additions & 22 deletions x-pack/filebeat/module/coredns/log/test/coredns.log-expected.json
Original file line number Diff line number Diff line change
@@ -1,18 +1,7 @@
[
{
"@timestamp": "2019-03-06T08:55:28.903Z",
"coredns.dnssec_ok": false,
"coredns.id": "21583",
"coredns.query.class": "IN",
"coredns.query.name": "httpbin.org.cluster.local.",
"coredns.query.size": 43,
"coredns.query.type": "A",
"coredns.response.code": "NXDOMAIN",
"coredns.response.flags": [
"QR",
"RA",
"RD"
],
"coredns.response.size": 136,
"dns.header_flags": [
"QR",
Expand Down Expand Up @@ -55,18 +44,7 @@
},
{
"@timestamp": "2019-03-18T22:13:36.289-07:00",
"coredns.dnssec_ok": false,
"coredns.id": "14639",
"coredns.query.class": "IN",
"coredns.query.name": "www.yahoo.com.",
"coredns.query.size": 42,
"coredns.query.type": "A",
"coredns.response.code": "NOERROR",
"coredns.response.flags": [
"QR",
"RA",
"RD"
],
"coredns.response.size": 188,
"dns.header_flags": [
"QR",
Expand Down