Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backwards compatibility with Golang 1.13.x to support Google Cloud Functions #27012

Closed
wants to merge 4 commits into from

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Jul 22, 2021

What does this PR do?

This PR adds backwards compatibility with Golang 1.13.x. The unsupported features were VerifyConnections introduced in #22495 and TLSDialContext from #25219

Why is it important?

Google Cloud Function run in Golang 1.13.8 environment. Previously, Beats only supported the version in the file .go-version. To make sure users can deploy and run Functionbeat on GCP these changes are required.

Also, we need to include some backwards compatibility smoke test or whatever so we are not breaking GCP functions in the future.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Closes #24925

@kvch kvch requested a review from urso July 22, 2021 12:04
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 22, 2021
@kvch kvch added bug Functionbeat Team:Elastic-Agent Label for the Agent team labels Jul 22, 2021
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 22, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@kvch kvch added backport-v7.14.0 Automated backport with mergify backport-v7.15.0 Automated backport with mergify labels Jul 22, 2021
@urso
Copy link

urso commented Jul 22, 2021

Is there a chance we can reduce the amount of copy and paste code?

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 22, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-07-22T13:09:09.197+0000

  • Duration: 142 min 2 sec

  • Commit: f81e97c

Test stats 🧪

Test Results
Failed 0
Passed 49440
Skipped 5396
Total 54836

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 49440
Skipped 5396
Total 54836

Copy link

@urso urso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That change hurts. I still see why it is supported for GCP support :(

@botelastic
Copy link

botelastic bot commented Aug 21, 2021

Hi!
We just realized that we haven't looked into this PR in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it in as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Aug 21, 2021
@mergify
Copy link
Contributor

mergify bot commented Sep 7, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b fix-functionbeat-gcp-tls upstream/fix-functionbeat-gcp-tls
git merge upstream/master
git push upstream fix-functionbeat-gcp-tls

@kvch
Copy link
Contributor Author

kvch commented Oct 5, 2021

New temp fix: #28251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.14.0 Automated backport with mergify backport-v7.15.0 Automated backport with mergify bug Functionbeat Stalled Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

functionbeat 7.12 can't deploy -- unknown field 'VerifyConnection' in struct literal of type tls.Config
3 participants