Set strings to be keywords by default #2688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsg
added
in progress
|
I tested the change with ES 5.0, I'm the process of testing with ES 2.4. |
ruflin
reviewed
Oct 5, 2016
| @@ -11,14 +11,13 @@ | |||
| }, | |||
| "dynamic_templates": [ | |||
| { | |||
| "fields": { | |||
There was a problem hiding this comment.
Nice that you gave it a name. Makes it much more readable.
There was a problem hiding this comment.
Yeah, it used to be the name of the dict/list field name. Now if everything is a keyword by default, the template also gets shorter, because we don't have dicts or lists of type text.
|
LGTM. This is a great addition to the #2627, in order to have a better upgrading support. |
|
Tested with ES 2.4, seems to be working OK. |
This adds a dynamic mapping to all our template files to set strings to be keywords by default. Previously we were using the default of `text` and only switching to `keyword` when configured in `fields.yml`. This reverses the logic and sets mappings to `text` only when requested in `fields.yml`. The goal is to make upgrading the mapping template less painful. In the Beats we have so far, unexpected fields are better of as keywords.
tsg
force-pushed
the
set_strings_as_keywords_by_default
branch
from
1fa4698
to
f414869
Compare
|
Added a Changelog entry. This could go in when green from my point of view. |
tsg
added a commit
to tsg/beats
that referenced
this pull request
Oct 5, 2016
This adds a dynamic mapping to all our template files to set strings to be keywords by default. Previously we were using the default of `text` and only switching to `keyword` when configured in `fields.yml`. This reverses the logic and sets mappings to `text` only when requested in `fields.yml`. The goal is to make upgrading the mapping template less painful. In the Beats we have so far, unexpected fields are better of as keywords.
andrewkroh
added a commit
that referenced
this pull request
Oct 5, 2016
Backport: Set strings to be keywords by default (#2688)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
This adds a dynamic mapping to all our template files to set strings to be keywords by default. Previously we were using the default of `text` and only switching to `keyword` when configured in `fields.yml`. This reverses the logic and sets mappings to `text` only when requested in `fields.yml`. The goal is to make upgrading the mapping template less painful. In the Beats we have so far, unexpected fields are better of as keywords.
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
Backport: Set strings to be keywords by default (elastic#2688)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a dynamic mapping to all our template files to set strings to be
keywords by default.
Previously we were using the default of
textand only switching tokeywordwhen configured in
fields.yml. This reverses the logic and sets mappings totextonly when requested infields.yml.The goal is to make upgrading the mapping template less painful. In the Beats
we have so far, unexpected fields are better of as keywords.