Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API keys do not reflect the need for read_pipeline #26466

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

philippkahr
Copy link
Contributor

@philippkahr philippkahr commented Jun 24, 2021

What does this PR do?

As discussed in the PR #26465 the docs should reflect that read_pipeline is needed when using modules. Users usually just copy and paste the JSON payload and might experience failures when running any beat with modules.

Additionally, this change should be reflected on all beats API key docs.

As discussed in the PR #26465 the docs should reflect that read_pipeline is needed when using modules. Users usually just copy and paste the JSON payload and might experience failures when running any beat with modules.
@philippkahr philippkahr added docs cleanup release-note:skip The PR should be ignored when processing the changelog labels Jun 24, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 24, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #26466 opened

  • Start Time: 2021-06-24T09:32:42.622+0000

  • Duration: 19 min 26 sec

  • Commit: e251a90

Trends 🧪

Image of Build Times

❕ Flaky test report

No test was executed to be analysed.

@jsoriano jsoriano added Team:Elastic-Agent Label for the Agent team Team:Docs Label for the Observability docs team labels Jun 24, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-docs (Team:Docs)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 24, 2021
@dedemorton dedemorton self-assigned this Jun 24, 2021
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a doc perspective, though I did not test the change to make sure it works.

@dedemorton
Copy link
Contributor

dedemorton commented Jun 24, 2021

Let me know if you want me to backport/forwardport this. Also, if there are other docs that require updates, can you create an issue in GitHub to describe the change? Thanks!

@philippkahr
Copy link
Contributor Author

Hi @dedemorton
thanks for that! Can you take care of the backport? Sorry for creating it on 7.13 and giving you extra work.

@dedemorton dedemorton merged commit b7c73c6 into 7.13 Jun 29, 2021
@dedemorton dedemorton deleted the philippkahr-patch-2 branch June 29, 2021 17:44
dedemorton pushed a commit to dedemorton/beats that referenced this pull request Jun 29, 2021
As discussed in the PR elastic#26465 the docs should reflect that read_pipeline is needed when using modules. Users usually just copy and paste the JSON payload and might experience failures when running any beat with modules.
dedemorton pushed a commit to dedemorton/beats that referenced this pull request Jun 29, 2021
As discussed in the PR elastic#26465 the docs should reflect that read_pipeline is needed when using modules. Users usually just copy and paste the JSON payload and might experience failures when running any beat with modules.
dedemorton added a commit that referenced this pull request Jun 29, 2021
As discussed in the PR #26465 the docs should reflect that read_pipeline is needed when using modules. Users usually just copy and paste the JSON payload and might experience failures when running any beat with modules.

Co-authored-by: Philipp Kahr <philipp.kahr@elastic.co>
dedemorton added a commit that referenced this pull request Jun 29, 2021
As discussed in the PR #26465 the docs should reflect that read_pipeline is needed when using modules. Users usually just copy and paste the JSON payload and might experience failures when running any beat with modules.

Co-authored-by: Philipp Kahr <philipp.kahr@elastic.co>
mdelapenya added a commit to mdelapenya/beats that referenced this pull request Jun 30, 2021
* master: (25 commits)
  fix: Force PLATFORMS environment variable when we build Elastic Agent dependencies on arm64 (elastic#26415)
  macos for metricbeat to run in the extended meta-stage (elastic#26573)
  Packaging: add arm7 platform in the main pipeline (elastic#26575)
  [Heartbeat] Skip flakey timer queue test (elastic#26592)
  Update to "read_pipeline" permission (elastic#26465) (elastic#26580)
  API keys do not reflect the need for read_pipeline (elastic#26466) (elastic#26582)
  Add Fleet agent.id to Agent monitoring data (elastic#26548)
  Add kinesis metricset (elastic#25989)
  Refactor of system/memory metricset (elastic#26334)
  Introduce httpcommon package in libbeat (add support for Proxy) (elastic#25219)
  [Filebeat] change multiline configuration in awss3 input to parsers (elastic#25873)
  docs: Hint for the error "Error extracting container id" (elastic#25824)
  [Docs] Fixed metricbeat redis exported field CPU descriptions (elastic#25846) (elastic#26496)
  Update urllib to 1.26.5. (elastic#26380)
  Update golang.org/x/crypto (elastic#26448)
  [Filebeat] Update Fortinet Ingest Pipeline (elastic#24816)
  Move parsers outside of filestream input so others can use them as well (elastic#26541)
  [Filebeat] Fix `threatintel.indicator.url.full` field not populating (elastic#26508)
  [Filebeat] Add network direction processor to Zeek and Suricata modules (elastic#24620)
  Logging code cleanup related to Nomad auto-discovery (elastic#26498)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup docs release-note:skip The PR should be ignored when processing the changelog Team:Docs Label for the Observability docs team Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants