Fix default Metricbeat config on Windows #2632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The load metricset is not supported on Windows, and if it's enabled in the configuration file, it makes Metricbeat exit immediately with an error. This change adjusted the configuration on Windows to exclude the load metricset. Fixes 2623.
tsg
added
review
needs_backport
|
@elastic/beats this solution works, but I'm not entirely happy with it, as I'd prefer to minimize the changes we do to the default configs. Should we consider a way of automatically disabling metricsets/modules based on the platform? |
|
An alternative solution is that instead of failing when a metricset does not exist that we want to load, that we only print an error. An option is to only log an error for the ones we exist but are not supported on this platform (special errors). The problem with the automatic disabling is that when a user configures it and is not aware that it is not supported under windows, he will complain that no data is sent. |
tsg
pushed a commit
to tsg/beats
that referenced
this pull request
Sep 23, 2016
ruflin
pushed a commit
that referenced
this pull request
Sep 23, 2016
tsg
added a commit
to tsg/beats
that referenced
this pull request
Sep 23, 2016
The load metricset is not supported on Windows, and if it's enabled in the configuration file, it makes Metricbeat exit immediately with an error. This change adjusted the configuration on Windows to exclude the load metricset. Fixes 2623.
tsg
added a commit
to tsg/beats
that referenced
this pull request
Sep 23, 2016
Merged
ruflin
pushed a commit
that referenced
this pull request
Sep 23, 2016
* Fix default Metricbeat config on Windows (#2632) The load metricset is not supported on Windows, and if it's enabled in the configuration file, it makes Metricbeat exit immediately with an error. This change adjusted the configuration on Windows to exclude the load metricset. Fixes 2623. * Changelog item for #2632 (#2635)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
* Fix default Metricbeat config on Windows (elastic#2632) The load metricset is not supported on Windows, and if it's enabled in the configuration file, it makes Metricbeat exit immediately with an error. This change adjusted the configuration on Windows to exclude the load metricset. Fixes 2623. * Changelog item for elastic#2632 (elastic#2635)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The load metricset is not supported on Windows, and if it's enabled
in the configuration file, it makes Metricbeat exit immediately with
an error.
This change adjusted the configuration on Windows to exclude the load
metricset.
Fixes #2623.