Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #25421 to 7.13: [Filebeat] Allow m365 defender to receive incidents with no alerts #25486

Merged
merged 2 commits into from
May 3, 2021

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented May 2, 2021

Cherry-pick of PR #25421 to 7.13 branch. Original message:

What does this PR do?

In some cases m365 creates incidents that simply reference other incidents, so empty alert arrays, this fixes the pipeline to take that into account, so there is no null def references in the conditions.

Fixed a small typo as well for some related fields.

Why is it important?

Fixes some small bugs with the module.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

…lastic#25421)

* allowing incidents with no alerts to be parsed, updating some typos and making the pipeline safer in terms of null def references

* adding changelog entry

* updating local test files

* reverting changes to json decoding, back to beat

(cherry picked from commit 733b655)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 2, 2021
@botelastic
Copy link

botelastic bot commented May 2, 2021

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

elasticmachine commented May 2, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #25486 updated

  • Start Time: 2021-05-02T11:28:47.439+0000

  • Duration: 53 min 50 sec

  • Commit: 9ff65e6

Test stats 🧪

Test Results
Failed 0
Passed 6981
Skipped 1193
Total 8174

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6981
Skipped 1193
Total 8174

@P1llus P1llus merged commit a744117 into elastic:7.13 May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants