Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Heartbeat] Fix null pointer in zip url on retry #25288

Merged
merged 2 commits into from
Apr 23, 2021
Merged

[Heartbeat] Fix null pointer in zip url on retry #25288

merged 2 commits into from
Apr 23, 2021

Conversation

andrewvc
Copy link
Contributor

@andrewvc andrewvc commented Apr 23, 2021 •
edited
Loading

Fixes a rare null pointer in synthetics zip url codepath

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@andrewvc andrewvc added bug Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.13.0 backport-v7.13.0 Automated backport with mergify labels Apr 23, 2021
@andrewvc andrewvc self-assigned this Apr 23, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 23, 2021
vigneshshanmugam
vigneshshanmugam approved these changes Apr 23, 2021
View reviewed changes
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #25288 opened

  • Start Time: 2021-04-23T19:27:43.701+0000

  • Duration: 55 min 47 sec

  • Commit: 7ffe1f0

Test stats 🧪

Test Results
Failed 0
Passed 69
Skipped 0
Total 69

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 69
Skipped 0
Total 69

@andrewvc andrewvc merged commit 42ad8ae into elastic:master Apr 23, 2021
mergify bot pushed a commit that referenced this pull request Apr 23, 2021
@andrewvc
[Heartbeat] Fix null pointer in zip url on retry (#25288)
1cceaca 
(cherry picked from commit 42ad8ae)
@mergify mergify bot mentioned this pull request Apr 23, 2021
Closed
@andrewvc
Copy link
Contributor Author

@Mergifyio backport 7.x

@mergify mergify bot mentioned this pull request Apr 23, 2021
Merged
@mergify
Copy link
Contributor

mergify bot commented Apr 23, 2021

Command backport 7.x: success

Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 23, 2021
@andrewvc
[Heartbeat] Fix null pointer in zip url on retry (#25288)
71cc539 
(cherry picked from commit 42ad8ae)
kvch pushed a commit that referenced this pull request Apr 27, 2021
@mergify @andrewvc
[Heartbeat] Fix null pointer in zip url on retry (#25288) (#25292)
f7f6b6a 
(cherry picked from commit 42ad8ae)

Co-authored-by: Andrew Cholakian <andrew@andrewvc.com>
@andrewvc andrewvc mentioned this pull request Apr 27, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshshanmugam vigneshshanmugam vigneshshanmugam approved these changes

Assignees

@andrewvc andrewvc

Labels
backport-v7.13.0 Automated backport with mergify bug Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewvc @elasticmachine @vigneshshanmugam