Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove id_field_data from our docker compose file #25239

Merged
merged 2 commits into from
Apr 26, 2021

Conversation

ph
Copy link
Contributor

@ph ph commented Apr 22, 2021

The id_field_data was added in #14850

From Elasticsearch's team recommendation this should not be used.

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

The `id_field_data` was added in elastic#14850

From Elasticsearch's team recommendation this should not be used.
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 22, 2021
@ph ph added the Team:Elastic-Agent Label for the Agent team label Apr 22, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 22, 2021
@ph ph added backport-v7.13.0 Automated backport with mergify backport-v7.14.0 Automated backport with mergify needs_team Indicates that the issue/PR needs a Team:* label labels Apr 22, 2021
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 22, 2021
@botelastic
Copy link

botelastic bot commented Apr 22, 2021

This pull request doesn't have a Team:<team> label.

@ph ph requested a review from mtojek April 22, 2021 14:02
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 22, 2021

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #25239 updated

  • Start Time: 2021-04-22T14:00:56.346+0000

  • Duration: 61 min 22 sec

  • Commit: 290e245

Test stats 🧪

Test Results
Failed 0
Passed 47256
Skipped 5149
Total 52405

Trends 🧪

Image of Build Times

Image of Tests

Steps errors 3

Expand to view the steps failures

generator-metricbeat-test - make -C generator/_templates/metricbeat test test-package
  • Took 6 min 18 sec . View more details on here
  • Description: make -C generator/_templates/metricbeat test test-package
generator-beat-test - make -C generator/_templates/beat test test-package
  • Took 7 min 17 sec . View more details on here
  • Description: make -C generator/_templates/beat test test-package
Error signal
  • Took 0 min 0 sec . View more details on here
  • Description: Error 'hudson.AbortException: script returned exit code 2'

Log output

Expand to view the last 100 lines of log output

[2021-04-22T15:01:35.831Z] 9.95s call     x-pack/filebeat/tests/system/test_xpack_modules.py::XPackTest::test_fileset_file_022_zscaler
[2021-04-22T15:01:35.831Z] 9.82s call     x-pack/filebeat/tests/system/test_xpack_modules.py::XPackTest::test_fileset_file_370_oracle
[2021-04-22T15:01:35.831Z] 9.80s call     x-pack/filebeat/tests/system/test_xpack_modules.py::XPackTest::test_fileset_file_035_juniper
[2021-04-22T15:01:35.831Z] 9.64s call     x-pack/filebeat/tests/system/test_xpack_modules.py::XPackTest::test_fileset_file_096_gcp
[2021-04-22T15:01:35.831Z] ======================= 402 passed in 1891.48s (0:31:31) =======================
[2021-04-22T15:01:36.090Z] >> python test: Integration Testing Complete
[2021-04-22T15:01:39.830Z] Cleaning up /var/lib/jenkins/workspace/PR-25239-2-eb0dd280-ff09-4118-82aa-ac8d546f9724
[2021-04-22T15:01:39.830Z] Client: Docker Engine - Community
[2021-04-22T15:01:39.830Z]  Version:           20.10.3
[2021-04-22T15:01:39.830Z]  API version:       1.41
[2021-04-22T15:01:39.830Z]  Go version:        go1.13.15
[2021-04-22T15:01:39.830Z]  Git commit:        48d30b5
[2021-04-22T15:01:39.830Z]  Built:             Fri Jan 29 14:33:13 2021
[2021-04-22T15:01:39.830Z]  OS/Arch:           linux/amd64
[2021-04-22T15:01:39.830Z]  Context:           default
[2021-04-22T15:01:39.831Z]  Experimental:      true
[2021-04-22T15:01:39.831Z] 
[2021-04-22T15:01:39.831Z] Server: Docker Engine - Community
[2021-04-22T15:01:39.831Z]  Engine:
[2021-04-22T15:01:39.831Z]   Version:          20.10.3
[2021-04-22T15:01:39.831Z]   API version:      1.41 (minimum version 1.12)
[2021-04-22T15:01:39.831Z]   Go version:       go1.13.15
[2021-04-22T15:01:39.831Z]   Git commit:       46229ca
[2021-04-22T15:01:39.831Z]   Built:            Fri Jan 29 14:31:25 2021
[2021-04-22T15:01:39.831Z]   OS/Arch:          linux/amd64
[2021-04-22T15:01:39.831Z]   Experimental:     false
[2021-04-22T15:01:39.831Z]  containerd:
[2021-04-22T15:01:39.831Z]   Version:          1.4.4
[2021-04-22T15:01:39.831Z]   GitCommit:        05f951a3781f4f2c1911b05e61c160e9c30eaa8e
[2021-04-22T15:01:39.831Z]  runc:
[2021-04-22T15:01:39.831Z]   Version:          1.0.0-rc93
[2021-04-22T15:01:39.831Z]   GitCommit:        12644e614e25b05da6fd08a38ffa0cfe1903fdec
[2021-04-22T15:01:39.831Z]  docker-init:
[2021-04-22T15:01:39.831Z]   Version:          0.19.0
[2021-04-22T15:01:39.831Z]   GitCommit:        de40ad0
[2021-04-22T15:01:39.831Z] Change ownership of all files inside the specific folder from root/root to current user/group
[2021-04-22T15:01:39.831Z] Unable to find image 'alpine:3.4' locally
[2021-04-22T15:01:40.414Z] 3.4: Pulling from library/alpine
[2021-04-22T15:01:40.675Z] c1e54eec4b57: Pulling fs layer
[2021-04-22T15:01:40.934Z] c1e54eec4b57: Verifying Checksum
[2021-04-22T15:01:40.934Z] c1e54eec4b57: Download complete
[2021-04-22T15:01:41.194Z] c1e54eec4b57: Pull complete
[2021-04-22T15:01:41.194Z] Digest: sha256:b733d4a32c4da6a00a84df2ca32791bb03df95400243648d8c539e7b4cce329c
[2021-04-22T15:01:41.194Z] Status: Downloaded newer image for alpine:3.4
[2021-04-22T15:01:43.102Z] Change permissions with write access of all files inside the specific folder
[2021-04-22T15:01:44.506Z] Running in /var/lib/jenkins/workspace/PR-25239-2-eb0dd280-ff09-4118-82aa-ac8d546f9724/src/github.com/elastic/beats/build
[2021-04-22T15:01:44.808Z] + rm -rf ve
[2021-04-22T15:01:44.808Z] + find . -type d -name vendor -exec rm -r {} ;
[2021-04-22T15:01:45.129Z] + python .ci/scripts/pre_archive_test.py
[2021-04-22T15:01:48.425Z] Copy ./x-pack/filebeat/build into build/x-pack/filebeat/build
[2021-04-22T15:01:48.447Z] Running in /var/lib/jenkins/workspace/PR-25239-2-eb0dd280-ff09-4118-82aa-ac8d546f9724/src/github.com/elastic/beats/build
[2021-04-22T15:01:48.466Z] Recording test results
[2021-04-22T15:01:52.602Z] [Checks API] No suitable checks publisher found.
[2021-04-22T15:01:53.003Z] + go clean -modcache
[2021-04-22T15:01:56.731Z] Cleaning up /var/lib/jenkins/workspace/PR-25239-2-eb0dd280-ff09-4118-82aa-ac8d546f9724
[2021-04-22T15:01:56.732Z] Client: Docker Engine - Community
[2021-04-22T15:01:56.732Z]  Version:           20.10.3
[2021-04-22T15:01:56.732Z]  API version:       1.41
[2021-04-22T15:01:56.732Z]  Go version:        go1.13.15
[2021-04-22T15:01:56.732Z]  Git commit:        48d30b5
[2021-04-22T15:01:56.732Z]  Built:             Fri Jan 29 14:33:13 2021
[2021-04-22T15:01:56.732Z]  OS/Arch:           linux/amd64
[2021-04-22T15:01:56.732Z]  Context:           default
[2021-04-22T15:01:56.732Z]  Experimental:      true
[2021-04-22T15:01:56.732Z] 
[2021-04-22T15:01:56.732Z] Server: Docker Engine - Community
[2021-04-22T15:01:56.732Z]  Engine:
[2021-04-22T15:01:56.732Z]   Version:          20.10.3
[2021-04-22T15:01:56.732Z]   API version:      1.41 (minimum version 1.12)
[2021-04-22T15:01:56.732Z]   Go version:       go1.13.15
[2021-04-22T15:01:56.732Z]   Git commit:       46229ca
[2021-04-22T15:01:56.732Z]   Built:            Fri Jan 29 14:31:25 2021
[2021-04-22T15:01:56.732Z]   OS/Arch:          linux/amd64
[2021-04-22T15:01:56.732Z]   Experimental:     false
[2021-04-22T15:01:56.732Z]  containerd:
[2021-04-22T15:01:56.732Z]   Version:          1.4.4
[2021-04-22T15:01:56.732Z]   GitCommit:        05f951a3781f4f2c1911b05e61c160e9c30eaa8e
[2021-04-22T15:01:56.732Z]  runc:
[2021-04-22T15:01:56.732Z]   Version:          1.0.0-rc93
[2021-04-22T15:01:56.732Z]   GitCommit:        12644e614e25b05da6fd08a38ffa0cfe1903fdec
[2021-04-22T15:01:56.732Z]  docker-init:
[2021-04-22T15:01:56.732Z]   Version:          0.19.0
[2021-04-22T15:01:56.732Z]   GitCommit:        de40ad0
[2021-04-22T15:01:56.732Z] Change ownership of all files inside the specific folder from root/root to current user/group
[2021-04-22T15:02:06.736Z] Change permissions with write access of all files inside the specific folder
[2021-04-22T15:02:06.777Z] Running in /var/lib/jenkins/workspace/PR-25239-2-eb0dd280-ff09-4118-82aa-ac8d546f9724
[2021-04-22T15:02:12.474Z] + gsutil --version
[2021-04-22T15:02:13.903Z] Masking supported pattern matches of $FILE_CREDENTIAL
[2021-04-22T15:02:14.225Z] + gcloud auth activate-service-account --key-file ****
[2021-04-22T15:02:14.793Z] Activated service account credentials for: [beats-ci-gcs-plugin@elastic-ci-prod.iam.gserviceaccount.com]
[2021-04-22T15:02:15.113Z] + gsutil -m -q cp -a public-read eC1wYWNrL2ZpbGViZWF0LWJ1aWxkMjkwZTI0NTc3N2UyZDVlM2EyYzQxOTM0OWRkOWFiOWZjNTFhNzAzZA gs://beats-ci-temp/ci/cache/
[2021-04-22T15:02:16.804Z] Stage "Packaging" skipped due to earlier failure(s)
[2021-04-22T15:02:16.892Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-25239/src/github.com/elastic/beats
[2021-04-22T15:02:17.436Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats_PR-25239
[2021-04-22T15:02:17.522Z] [INFO] getVaultSecret: Getting secrets
[2021-04-22T15:02:17.627Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-04-22T15:02:18.473Z] + chmod 755 generate-build-data.sh
[2021-04-22T15:02:18.473Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-25239/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-25239/runs/2 FAILURE 3681855
[2021-04-22T15:02:19.023Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-25239/runs/2/steps/?limit=10000 -o steps-info.json
[2021-04-22T15:02:31.247Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-25239/runs/2/tests/?status=FAILED -o tests-errors.json

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 47256
Skipped 5149
Total 52405

@ph
Copy link
Contributor Author

ph commented Apr 22, 2021

Jenkins test this

@ph ph merged commit 2ccf3d7 into elastic:master Apr 26, 2021
mergify bot pushed a commit that referenced this pull request Apr 26, 2021
* Remove id_field_data from our docker compose file

The `id_field_data` was added in #14850

From Elasticsearch's team recommendation this should not be used.

* Changelog

(cherry picked from commit 2ccf3d7)

# Conflicts:
#	testing/environments/snapshot.yml
mergify bot pushed a commit that referenced this pull request Apr 26, 2021
* Remove id_field_data from our docker compose file

The `id_field_data` was added in #14850

From Elasticsearch's team recommendation this should not be used.

* Changelog

(cherry picked from commit 2ccf3d7)

# Conflicts:
#	testing/environments/snapshot.yml
@jasontedor
Copy link
Member

Thanks @ph!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.13.0 Automated backport with mergify backport-v7.14.0 Automated backport with mergify Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants