Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add http.request.id to nginx/ingress_controller and elasticsearch/audit #24994

Merged
merged 2 commits into from
Apr 8, 2021
Merged

Add http.request.id to nginx/ingress_controller and elasticsearch/audit #24994

merged 2 commits into from
Apr 8, 2021

Conversation

andrewstucki
Copy link
Contributor

What does this PR do?

This adds the ECS 1.9 http.request.id field to nginx/ingress_controller and elasticsearch/audit filesets.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@andrewstucki andrewstucki requested a review from a team April 8, 2021 18:15
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 8, 2021
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 8, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 8, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24994 updated

  • Start Time: 2021-04-08T18:17:23.851+0000

  • Duration: 53 min 39 sec

  • Commit: 9475d25

Test stats 🧪

Test Results
Failed 0
Passed 13464
Skipped 2271
Total 15735

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 13464
Skipped 2271
Total 15735

@andrewstucki andrewstucki mentioned this pull request Apr 8, 2021
Closed
2 tasks
andrewkroh
andrewkroh approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewstucki andrewstucki merged commit 23e4403 into elastic:master Apr 8, 2021
mergify bot pushed a commit that referenced this pull request Apr 8, 2021
Add http.request.id to nginx/ingress_controller and elasticsearch/aud…
2e28803 
…it (#24994)

* Add http.request.id to nginx/ingress_controller and elasticsearch/audit

* Add changelog entry

(cherry picked from commit 23e4403)
@mergify mergify bot mentioned this pull request Apr 8, 2021
Merged
andrewstucki pushed a commit that referenced this pull request Apr 9, 2021
@mergify
Add http.request.id to nginx/ingress_controller and elasticsearch/aud…
50d12a5 
…it (#24994) (#24999)

* Add http.request.id to nginx/ingress_controller and elasticsearch/audit

* Add changelog entry

(cherry picked from commit 23e4403)

Co-authored-by: Andrew Stucki <andrew.stucki@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
backport-v7.13.0 Automated backport with mergify ecs enhancement Filebeat Filebeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewstucki @elasticmachine @andrewkroh