Cherry-pick #23579 to 7.x: Fix flaky TestConfigurable* unit tests #23591
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #23579 to 7.x branch. Original message:
What does this PR do?
This PR adds a waitFor clause to
TestConfigurableRun
andTestConfigurableService
tests.Sometimes it happened that we were checking if process is not running anymore by checking
state != Running
but the process was (due to heavier load on the CI machine) still in the Configuring state. This condition then evaluated that process is not running and failed test.Now we perform this check after we verify that status exited Configuring.
As i'm reenabling
TestConfigurableService
i will rekick tests multiple times and watch weekly failures mail.Why is it important?
Flaky tests #20836
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.