Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder headers for infoblox module #23273

Merged
merged 2 commits into from
Dec 28, 2020

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Dec 23, 2020

What does this PR do?

This reorders the syslog headers parsers for the infoblox/nios dataset so that the simpler header is picked up first.

Why is it important?

Otherwise it will fail to parse logs in the default configuration.

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Fixes #23272

This reorders the syslog headers parsers for the infoblox/nios dataset
so that the simpler header is picked up first. Otherwise it will
fail to properly parse logs.

Fixes elastic#23272
@adriansr adriansr added bug review needs_backport PR is waiting to be backported to other branches. Team:Security-External Integrations labels Dec 23, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 23, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 23, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23273 updated

  • Start Time: 2020-12-23T16:16:41.065+0000

  • Duration: 48 min 48 sec

Test stats 🧪

Test Results
Failed 0
Passed 2445
Skipped 263
Total 2708

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2445
Skipped 263
Total 2708

@adriansr adriansr merged commit 27d0f08 into elastic:master Dec 28, 2020
adriansr added a commit to adriansr/beats that referenced this pull request Dec 28, 2020
* Reorder headers for infoblox module

This reorders the syslog headers parsers for the infoblox/nios dataset
so that the simpler header is picked up first. Otherwise it will
fail to properly parse logs.

Fixes elastic#23272

* Changelog entry

(cherry picked from commit 27d0f08)
@adriansr adriansr added v7.12.0 and removed needs_backport PR is waiting to be backported to other branches. labels Dec 28, 2020
adriansr added a commit that referenced this pull request Dec 28, 2020
* Reorder headers for infoblox module

This reorders the syslog headers parsers for the infoblox/nios dataset
so that the simpler header is picked up first. Otherwise it will
fail to properly parse logs.

Fixes #23272

* Changelog entry

(cherry picked from commit 27d0f08)
adriansr added a commit to adriansr/beats that referenced this pull request Dec 28, 2020
* Reorder headers for infoblox module

This reorders the syslog headers parsers for the infoblox/nios dataset
so that the simpler header is picked up first. Otherwise it will
fail to properly parse logs.

Fixes elastic#23272

* Changelog entry

(cherry picked from commit 27d0f08)
adriansr added a commit that referenced this pull request Dec 29, 2020
* Reorder headers for infoblox module

This reorders the syslog headers parsers for the infoblox/nios dataset
so that the simpler header is picked up first. Otherwise it will
fail to properly parse logs.

Fixes #23272

* Changelog entry

(cherry picked from commit 27d0f08)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infoblox nios wrong syslog parsing
3 participants