simplify regex for org & custom prefix in aws/cloudtrail #23204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
leehinman
added
bug
Filebeat
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
removed
the
needs_team
- only match on /CloudTrail/, /CloudTrail-Digest/ and /CloudTrail-Insight/, ignore variable prefix Closes elastic#23203
leehinman
force-pushed
the
23203_cloudtrail_ou-id
branch
from
9b3510a
to
311a505
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
2 tasks
leehinman
added
v7.12.0
and removed
needs_backport
leehinman
added a commit
to leehinman/beats
that referenced
this pull request
Dec 17, 2020
- only match on /CloudTrail/, /CloudTrail-Digest/ and /CloudTrail-Insight/, ignore variable prefix Closes elastic#23203 (cherry picked from commit 6935dc6)
leehinman
added a commit
to leehinman/beats
that referenced
this pull request
Dec 17, 2020
- only match on /CloudTrail/, /CloudTrail-Digest/ and /CloudTrail-Insight/, ignore variable prefix Closes elastic#23203 (cherry picked from commit 6935dc6)
2 tasks
leehinman
added a commit
that referenced
this pull request
Dec 18, 2020
leehinman
added a commit
that referenced
this pull request
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
changes regex to only match on /CloudTrail/, /CloudTrail-Digest/ and
/CloudTrail-Insight/. This removes the prefix which is variable based
on custom prefix and organization.
Why is it important?
cloudtrail will work if you have custom prefix or organization. And
you will still be able to skip Digest or Insight logs if necessary.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Need to test in AWS with custom prefix or organization. Did test
regex against known cloudtrail filename patterns.
Related issues