Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] Allow cef and checkpoint modules to override network directionality based off of zones #23066

Conversation

andrewstucki
Copy link
Contributor

@andrewstucki andrewstucki commented Dec 10, 2020

What does this PR do?

This adopts the same logic as #22998 by classifying internal/external/inbound/outbound traffic based off of zones.

It differs due to the fact that the checkpoint module (and the cef module when used with checkpoint) already fill in a network direction based off of a field in the actual event payload that says either "inbound" or "outbound". That said, this change would allow internal/external traffic classification and classifying logically based off of logical network segments in a partitioned network where some zones are considered inside of a DMZ v. outside.

By default the classification overriding is turned off.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 10, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 10, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23066 updated

  • Start Time: 2020-12-10T19:15:25.680+0000

  • Duration: 69 min 42 sec

Test stats 🧪

Test Results
Failed 0
Passed 2422
Skipped 261
Total 2683

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2422
Skipped 261
Total 2683

@andrewstucki
Copy link
Contributor Author

Since there's no way of overriding the config on a per golden file basis. Here's a diff to demonstrate this working:

With the following configuration change

diff --git a/x-pack/filebeat/module/checkpoint/firewall/manifest.yml b/x-pack/filebeat/module/checkpoint/firewall/manife
st.yml
index 5d5d3dd4d..83475c65a 100644
--- a/x-pack/filebeat/module/checkpoint/firewall/manifest.yml
+++ b/x-pack/filebeat/module/checkpoint/firewall/manifest.yml
@@ -11,7 +11,9 @@ var:
     default: syslog
   - name: ssl
   - name: internal_zones
+    default: ['Internal'] # I want it backwards for effect
   - name: external_zones
+    default: ['Local'] # I want it backwards for effect

 ingest_pipeline:
   - ingest/pipeline.yml

We see the following change:

@@ -176,7 +176,7 @@
         "input.type": "log",
         "log.offset": 1739,
         "network.application": "https",
-        "network.direction": "outbound",
+        "network.direction": "inbound",
         "network.iana_number": "6",
         "network.name": "Network",
         "observer.egress.interface.name": "eth0",

@andrewstucki andrewstucki merged commit f52e452 into elastic:master Dec 10, 2020
@andrewstucki andrewstucki deleted the checkpoint-cef-network-direction-override branch December 10, 2020 20:26
andrewstucki pushed a commit to andrewstucki/beats that referenced this pull request Dec 10, 2020
…tionality based off of zones (elastic#23066)

* [Filebeat] Allow cef and checkpoint modules to override network directionality based off of zones

* Remove _temp_

* Add changelog entry

* run mage update and add variable reference

* Don't override categorization if no zone set

* Update cef pipeline

(cherry picked from commit f52e452)
andrewstucki pushed a commit that referenced this pull request Dec 10, 2020
…s to override network directionality based off of zones (#23082)

* [Filebeat] Allow cef and checkpoint modules to override network directionality based off of zones (#23066)

* [Filebeat] Allow cef and checkpoint modules to override network directionality based off of zones

* Remove _temp_

* Add changelog entry

* run mage update and add variable reference

* Don't override categorization if no zone set

* Update cef pipeline

(cherry picked from commit f52e452)

* Fix up changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants