Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clusterName, taskName, cloud.region and dashboard to aws fargate #22941

Merged
merged 3 commits into from
Dec 9, 2020
Merged

Add clusterName, taskName, cloud.region and dashboard to aws fargate #22941

merged 3 commits into from
Dec 9, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Dec 5, 2020

What does this PR do?

This PR is to add extra fields for cluster name, task name, cloud region and an identifier for AWS fargate.

Why is it important?

When creating AWS Fargate tasks with the same container/container name, Kibana dashboard get confused and only displaying part of the data. I would like to introduce an awsfargate.identifier = containerName + "/" + containerID to make sure we can distinguish containers from different task or cluster.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Screenshot

metricbeat-awsfargate-overview

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 5, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Dec 5, 2020
@kaiyan-sheng kaiyan-sheng added needs_backport PR is waiting to be backported to other branches. Team:Platforms Label for the Integrations - Platforms team labels Dec 5, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 5, 2020
@kaiyan-sheng kaiyan-sheng added the in progress Pull request is currently in progress. label Dec 5, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 5, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #22941 updated

  • Start Time: 2020-12-08T18:08:03.375+0000

  • Duration: 55 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 2703
Skipped 593
Total 3296

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2703
Skipped 593
Total 3296

@kaiyan-sheng kaiyan-sheng changed the title Add clusterName, taskName and cloud.region to aws fargate Add clusterName, taskName, cloud.region and dashboard to aws fargate Dec 8, 2020
@kaiyan-sheng kaiyan-sheng added review and removed in progress Pull request is currently in progress. labels Dec 8, 2020
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks!

@kaiyan-sheng kaiyan-sheng merged commit 7cbb1a2 into elastic:master Dec 9, 2020
@kaiyan-sheng kaiyan-sheng deleted the awsfargate_cluster branch December 9, 2020 14:38
@kaiyan-sheng kaiyan-sheng added v7.11.0 and removed needs_backport PR is waiting to be backported to other branches. labels Dec 9, 2020
kaiyan-sheng added a commit that referenced this pull request Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Platforms Label for the Integrations - Platforms team v7.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants