Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix index template loading when the new index is selected #22682

Merged
merged 7 commits into from
Nov 24, 2020

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Nov 20, 2020

What does this PR do?

This PR fixes the setup.template.type setting. When index were selected, Beats based the generated index on the legacy format, not on the component. This prevented Beats from loading the index.

Why is it important?

setup.template.type=index was broken. Now it is fixed.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

./filebeat setup --index-management -E setup.template.type=index

Related issues

Closes #22482

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 20, 2020
@kvch kvch added the Team:Services (Deprecated) Label for the former Integrations-Services team label Nov 20, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 20, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 20, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22682 updated]

  • Start Time: 2020-11-23T19:23:20.545+0000

  • Duration: 58 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 16661
Skipped 1369
Total 18030

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 16661
Skipped 1369
Total 18030

@kvch kvch force-pushed the fix-filebeat-template-index-load branch from cce08e8 to 6ce09da Compare November 23, 2020 15:09
Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change looks ok

@kvch kvch merged commit 569268d into elastic:master Nov 24, 2020
@kvch kvch added the needs_backport PR is waiting to be backported to other branches. label Nov 24, 2020
kvch added a commit to kvch/beats that referenced this pull request Nov 24, 2020
)

## What does this PR do?

This PR fixes the `setup.template.type` setting. When `index` were selected, Beats based the generated index on the legacy format, not on the component. This prevented Beats from loading the index.

## Why is it important?

`setup.template.type=index` was broken. Now it is fixed.

## How to test this PR locally

```
./filebeat setup --index-management -E setup.template.type=index
```

## Related issues

Closes elastic#22482

(cherry picked from commit 569268d)
@kvch kvch added v7.11.0 and removed needs_backport PR is waiting to be backported to other branches. labels Nov 24, 2020
@kvch kvch added the v7.10.1 label Nov 24, 2020
kvch added a commit to kvch/beats that referenced this pull request Nov 24, 2020
)

This PR fixes the `setup.template.type` setting. When `index` were selected, Beats based the generated index on the legacy format, not on the component. This prevented Beats from loading the index.

`setup.template.type=index` was broken. Now it is fixed.

```
./filebeat setup --index-management -E setup.template.type=index
```

Closes elastic#22482

(cherry picked from commit 569268d)
kvch added a commit that referenced this pull request Nov 25, 2020
…22742)

This PR fixes the `setup.template.type` setting. When `index` were selected, Beats based the generated index on the legacy format, not on the component. This prevented Beats from loading the index.

`setup.template.type=index` was broken. Now it is fixed.

```
./filebeat setup --index-management -E setup.template.type=index
```

Closes #22482

(cherry picked from commit 569268d)
kvch added a commit that referenced this pull request Nov 25, 2020
…22741)

## What does this PR do?

This PR fixes the `setup.template.type` setting. When `index` were selected, Beats based the generated index on the legacy format, not on the component. This prevented Beats from loading the index.

## Why is it important?

`setup.template.type=index` was broken. Now it is fixed.

## How to test this PR locally

```
./filebeat setup --index-management -E setup.template.type=index
```

## Related issues

Closes #22482

(cherry picked from commit 569268d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Services (Deprecated) Label for the former Integrations-Services team v7.10.1 v7.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to load index template of type index
3 participants