Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat][Cisco Umbrella module] Adding missing timeout options and fixing module config.yml #22295

Merged
merged 1 commit into from
Oct 30, 2020

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Oct 30, 2020

What does this PR do?

This fixes missing config items for Cisco Umbrella, might have been missing from the start or been removed during a merge.

Why is it important?

Umbrella fileset needs the config parameters to function.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 30, 2020
@elasticmachine
Copy link
Collaborator

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 4474
Skipped 561
Total 5035

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22295 opened]

  • Start Time: 2020-10-30T09:47:56.553+0000

  • Duration: 53 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 4474
Skipped 561
Total 5035

@marc-gr marc-gr merged commit b18b333 into elastic:master Oct 30, 2020
marc-gr pushed a commit to marc-gr/beats that referenced this pull request Oct 30, 2020
…g options in module config.yml (elastic#22295)

(cherry picked from commit b18b333)
marc-gr pushed a commit to marc-gr/beats that referenced this pull request Oct 30, 2020
…g options in module config.yml (elastic#22295)

(cherry picked from commit b18b333)
@P1llus P1llus deleted the filebeat_umbrella_settings branch October 30, 2020 11:34
v1v added a commit to v1v/beats that referenced this pull request Oct 30, 2020
* upstream/master:
  adding timeout options to cisco umbrella and fixing the missing config options in module config.yml (elastic#22295)
  [Metricbeat] Remove io.time from windows (elastic#22237)
  remove debug messages (elastic#22282)
  dependency upgrade: ecszap v0.3.0 (elastic#22267)
  [repo] Add docs + cleanup labels to the categories in the incoming PR template (elastic#22280)
v1v added a commit to v1v/beats that referenced this pull request Oct 30, 2020
* upstream/master:
  adding timeout options to cisco umbrella and fixing the missing config options in module config.yml (elastic#22295)
  [Metricbeat] Remove io.time from windows (elastic#22237)
  remove debug messages (elastic#22282)
  dependency upgrade: ecszap v0.3.0 (elastic#22267)
  [repo] Add docs + cleanup labels to the categories in the incoming PR template (elastic#22280)
marc-gr added a commit that referenced this pull request Nov 2, 2020
…g options in module config.yml (#22295) (#22299)

(cherry picked from commit b18b333)

Co-authored-by: Marius Iversen <pillus@chasenet.org>
marc-gr added a commit that referenced this pull request Nov 2, 2020
…g options in module config.yml (#22295) (#22298)

(cherry picked from commit b18b333)

Co-authored-by: Marius Iversen <pillus@chasenet.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants