-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat][Cisco Umbrella module] Adding missing timeout options and fixing module config.yml #22295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g options in module config.yml
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Oct 30, 2020
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
marc-gr
approved these changes
Oct 30, 2020
5 tasks
marc-gr
pushed a commit
to marc-gr/beats
that referenced
this pull request
Oct 30, 2020
…g options in module config.yml (elastic#22295) (cherry picked from commit b18b333)
5 tasks
marc-gr
pushed a commit
to marc-gr/beats
that referenced
this pull request
Oct 30, 2020
…g options in module config.yml (elastic#22295) (cherry picked from commit b18b333)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 30, 2020
* upstream/master: adding timeout options to cisco umbrella and fixing the missing config options in module config.yml (elastic#22295) [Metricbeat] Remove io.time from windows (elastic#22237) remove debug messages (elastic#22282) dependency upgrade: ecszap v0.3.0 (elastic#22267) [repo] Add docs + cleanup labels to the categories in the incoming PR template (elastic#22280)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 30, 2020
* upstream/master: adding timeout options to cisco umbrella and fixing the missing config options in module config.yml (elastic#22295) [Metricbeat] Remove io.time from windows (elastic#22237) remove debug messages (elastic#22282) dependency upgrade: ecszap v0.3.0 (elastic#22267) [repo] Add docs + cleanup labels to the categories in the incoming PR template (elastic#22280)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes missing config items for Cisco Umbrella, might have been missing from the start or been removed during a merge.
Why is it important?
Umbrella fileset needs the config parameters to function.
Checklist
- [ ] I have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.