Rename google-pubsub Filebeat input to gcp-pubsub

[kaiyan-sheng]

What does this PR do?

This PR is to rename google-pubsub input to gcp-pubsub input. This is a part of the renaming process to change googlecloud to gcp in both Metricbeat and Filebeat.

Warning log message is also added when user is using the old input name:

2020-10-28T13:54:08.841-0600    WARN    [gcp.pubsub]    gcppubsub/input.go:79   google-pubsub input name is deprecated, please use gcp-pubsub instead   {"pubsub_project": "elastic-observability", "pubsub_topic": "my-gcp-pubsub-topic-name", "pubsub_subscription": {"Name":"my-gcp-pubsub-subscription-name","NumGoroutines":1,"MaxOutstandingMessages":1000,"Create":true}}

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

This should not be a breaking change so both google-pubsub and gcp-pubsub input names should work.

1. Test google-pubsub name:

filebeat.inputs:
- type: google-pubsub
  enabled: true
  project_id: elastic-observability
  topic: my-gcp-pubsub-topic-name
  subscription.name: my-gcp-pubsub-subscription-name
  credentials_file: "/Users/kaiyansheng/Desktop/elastic-observability-5537b831234a.json"

1. Test gcp-pubsub name:

filebeat.inputs:
- type: gcp-pubsub
  enabled: true
  project_id: elastic-observability
  topic: my-gcp-pubsub-topic-name
  subscription.name: my-gcp-pubsub-subscription-name
  credentials_file: "/Users/kaiyansheng/Desktop/elastic-observability-5537b831234a.json"

Related issues

• Relates Fix inconsistency of GCP Filebeat/Metricbeat names #19467

[elasticmachine]

Pinging @elastic/integrations-platforms (Team:Platforms)

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Build Cause: [Pull request #22213 updated]

• Start Time: 2020-11-03T23:13:59.861+0000

• Duration: 47 min 8 sec

Test stats 🧪

Test	Results
Failed	0
Passed	5859
Skipped	567
Total	6426

[andrewkroh]

When will the old input name be removed? If 8.0 then after this is backported into 7.x we could remove the old name from master.

In the release note we could say something like "the previous name will continue working until the next major release. Please update your configs".

[elasticmachine]

Pinging @elastic/ingest-management (Team:Ingest Management)

[elasticmachine]

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test	Results
Failed	0
Passed	5859
Skipped	567
Total	6426

[ph]

@kaiyan-sheng Is there any integration using this input? if so they would need to be changed as well.

[kaiyan-sheng]

@ph Thanks for reminding me. I don't think so. We only migrated AWS package with s3 input, not GCP.

[andrewkroh]

LGTM