Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[proposed Enhancement] Update monitoring-metricbeat.asciidoc #21863

Merged
merged 1 commit into from
Dec 22, 2020
Merged

[proposed Enhancement] Update monitoring-metricbeat.asciidoc #21863

merged 1 commit into from
Dec 22, 2020

Conversation

nagor
Copy link
Contributor

@nagor nagor commented Oct 15, 2020

What does this PR do?

Minor fix in the configuration of Beats for monitoring.

Why is it important?

The lack of cluster configuration is a bit misleading.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 15, 2020
@cla-checker-service
Copy link

cla-checker-service bot commented Oct 15, 2020 •
edited
Loading

💚 CLA has been signed

@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 15, 2020 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Branch indexing

  • Start Time: 2020-12-17T09:30:30.487+0000

  • Duration: 9 min 59 sec

@nagor
Copy link
Contributor Author

nagor commented Oct 15, 2020

Signed contributor agreement

@andresrc andresrc added the Team:Docs Label for the Observability docs team label Oct 16, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-docs (Team:Docs)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 16, 2020
@bmorelli25
Copy link
Member

bmorelli25 commented Oct 16, 2020 •
edited
Loading

Thanks, @nagor! I'll rerun the tests.

@elasticmachine, run elasticsearch-ci/docs

Tagging @dedemorton for review as she knows more about this topic than I do.

@bmorelli25 bmorelli25 requested a review from dedemorton October 16, 2020 15:13
@bmorelli25
Copy link
Member

jenkins rerun the tests please

dedemorton
dedemorton approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! My apologies for the review delay. This got lost in my Inbox.

Thanks for your contribution!

@dedemorton
Copy link
Contributor

Note that I will backport this PR to relevant branches after it's merged.

@chrisronline
Copy link
Contributor

chrisronline commented Dec 8, 2020 •
edited
Loading

cc @sayden @ycombinator @andresrc to verify this PR

@andresrc andresrc requested a review from sayden December 16, 2020 09:05
@dedemorton dedemorton merged commit 11f9ab1 into elastic:7.9 Dec 22, 2020
This was referenced Dec 22, 2020
Merged
Merged
Merged
dedemorton pushed a commit to dedemorton/beats that referenced this pull request Dec 22, 2020
@nagor @dedemorton
Update monitoring-metricbeat.asciidoc (elastic#21863)
9aea519
dedemorton pushed a commit to dedemorton/beats that referenced this pull request Dec 22, 2020
@nagor @dedemorton
Update monitoring-metricbeat.asciidoc (elastic#21863)
86de448
@dedemorton dedemorton mentioned this pull request Dec 22, 2020
Merged
dedemorton pushed a commit to dedemorton/beats that referenced this pull request Dec 22, 2020
@nagor @dedemorton
Update monitoring-metricbeat.asciidoc (elastic#21863)
fc3bc91
dedemorton added a commit that referenced this pull request Dec 22, 2020
@dedemorton @nagor
Update monitoring-metricbeat.asciidoc (#21863) (#23233)
e1e0c16 
Co-authored-by: Roman Nagorkin <roman.nagorkin@gmail.com>
dedemorton added a commit that referenced this pull request Dec 22, 2020
@dedemorton @nagor
Update monitoring-metricbeat.asciidoc (#21863) (#23232)
034d5b9 
Co-authored-by: Roman Nagorkin <roman.nagorkin@gmail.com>
dedemorton added a commit that referenced this pull request Dec 22, 2020
@dedemorton @nagor
Update monitoring-metricbeat.asciidoc (#21863) (#23231)
b3c22da 
Co-authored-by: Roman Nagorkin <roman.nagorkin@gmail.com>
dedemorton pushed a commit to dedemorton/beats that referenced this pull request Jan 5, 2021
@nagor @dedemorton
Update monitoring-metricbeat.asciidoc (elastic#21863)
6196b9a
dedemorton added a commit that referenced this pull request Jan 5, 2021
@dedemorton @nagor
Update monitoring-metricbeat.asciidoc (#21863) (#23230)
a361ee3 
Co-authored-by: Roman Nagorkin <roman.nagorkin@gmail.com>
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@nagor
Update monitoring-metricbeat.asciidoc (elastic#21863)
98e5e15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayden sayden sayden approved these changes

@dedemorton dedemorton dedemorton approved these changes

Assignees

@bmorelli25 bmorelli25

Labels
Team:Docs Label for the Observability docs team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nagor @elasticmachine @bmorelli25 @dedemorton @chrisronline @sayden @andresrc