Cherry-pick #21751 to 7.x: Add proxy metricset #21834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit fc10f06)
ChrsMark
added
[zube]: In Review
backport
Team:Platforms
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
exekias
reviewed
Oct 15, 2020
| metricbeat.autodiscover: | ||
| providers: | ||
| - type: kubernetes | ||
| include_annotations: ["prometheus.io.scrape"] |
There was a problem hiding this comment.
I see you are not using this at all, is this line needed?
There was a problem hiding this comment.
nope it's not! I will remove it to avoid confusion 👍
There was a problem hiding this comment.
sorry I saw now this is a backport, we will need to remove it from master too
exekias
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #21751 to 7.x branch. Original message:
What does this PR do?
This PR adds
proxymetricset. It leverages theuse_typesoption.istiod(#21519) : light-weight metricset on top of Prometheus to collect metrics from the Prometheus exporter of Istio Daemonproxy: light-weight metricset on top of Prometheus to collect metrics from the Prometheus exporter of each of the proxy sidecars. It is recommended (and documented 🙂 ) to leverage autodiscover feature to enable this metricset so as to dynamically identify sidecars and start monitoring them.Why is it important?
To be compatible with versions of Istio higher than
1.5.Related issues