Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add add_observer_metadata geo.name to Quickstart #21501

Merged
merged 3 commits into from
Oct 7, 2020
Merged

Add add_observer_metadata geo.name to Quickstart #21501

merged 3 commits into from
Oct 7, 2020

Conversation

DanRoscigno
Copy link
Contributor

The observer location is very important in the Uptime app and the out-of-the-box machine learning job.

Please label this PR with one of the following labels, depending on the scope of your change:

  • Bug

What does this PR do?

After following the Quickstart the out-of-the-box ML job will not work, as it requires the observer location.

Why is it important?

The user experience is not correct if the anomaly does not work, and the user will not know what to do.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

How to test this PR locally

Follow the Quickstart and then enable anomaly detection in Uptime, and then add the geo.name and try it again.

Related issues

@DanRoscigno
Add add_observer_metadata geo.name to Quickstart
4c689e9 
The observer location is very important in the Uptime app and the out-of-the-box machine learning job.
@DanRoscigno DanRoscigno requested a review from a team as a code owner October 2, 2020 22:17
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 2, 2020
@DanRoscigno DanRoscigno requested a review from dedemorton October 2, 2020 22:17
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 2, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21501 updated]

  • Start Time: 2020-10-07T02:37:08.875+0000

  • Duration: 26 min 11 sec

@DanRoscigno
Update getting-started.asciidoc
4f3d4ed 
The instructions about editing heartbeat.yml were too wordy
@andresrc andresrc added the Team:Docs Label for the Observability docs team label Oct 3, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-docs (Team:Docs)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 3, 2020
@andresrc andresrc added needs_team Indicates that the issue/PR needs a Team:* label and removed Team:Docs Label for the Observability docs team labels Oct 3, 2020
@DanRoscigno DanRoscigno added the Team:Docs Label for the Observability docs team label Oct 6, 2020
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 6, 2020
@DanRoscigno DanRoscigno requested a review from EamonnTP October 6, 2020 13:39
@DanRoscigno
Copy link
Contributor Author

@EamonnTP I think this one is needed for anomaly detection in Uptime. Without the observer.geo.name field populated I think the out-of-the-box ML job will not work as it looks by geo. Can you have a look please?

@EamonnTP
Copy link

EamonnTP commented Oct 6, 2020

@dedemorton Now that we reuse content in the Observability guide, should a tagged region be used for this new content?

@DanRoscigno @dedemorton
tighten it up!
6ecc606 
Co-authored-by: DeDe Morton <dede.morton@elastic.co>
@DanRoscigno DanRoscigno merged commit 36953df into master Oct 7, 2020
@DanRoscigno DanRoscigno deleted the DanRoscigno-add-observer.geo.name branch October 7, 2020 13:59
@DanRoscigno
Copy link
Contributor Author

@EamonnTP can you back port it to 7.9 please?

@EamonnTP
Copy link

EamonnTP commented Oct 7, 2020

@DanRoscigno No problem, will do.

@EamonnTP EamonnTP mentioned this pull request Oct 7, 2020
Merged
EamonnTP pushed a commit to EamonnTP/beats that referenced this pull request Oct 7, 2020
@DanRoscigno @dedemorton
Add add_observer_metadata geo.name to Quickstart (elastic#21501)
a4601f3 
* Add `add_observer_metadata` `geo.name` to Quickstart

The observer location is very important in the Uptime app and the out-of-the-box machine learning job.

* Update getting-started.asciidoc

The instructions about editing heartbeat.yml were too wordy

* tighten it up!

Co-authored-by: DeDe Morton <dede.morton@elastic.co>

Co-authored-by: DeDe Morton <dede.morton@elastic.co>
@EamonnTP EamonnTP mentioned this pull request Oct 7, 2020
Merged
EamonnTP pushed a commit to EamonnTP/beats that referenced this pull request Oct 7, 2020
@DanRoscigno @dedemorton
Add add_observer_metadata geo.name to Quickstart (elastic#21501)
8a4f1e7 
* Add `add_observer_metadata` `geo.name` to Quickstart

The observer location is very important in the Uptime app and the out-of-the-box machine learning job.

* Update getting-started.asciidoc

The instructions about editing heartbeat.yml were too wordy

* tighten it up!

Co-authored-by: DeDe Morton <dede.morton@elastic.co>

Co-authored-by: DeDe Morton <dede.morton@elastic.co>
EamonnTP pushed a commit to EamonnTP/beats that referenced this pull request Oct 7, 2020
@DanRoscigno @dedemorton
Add add_observer_metadata geo.name to Quickstart (elastic#21501)
442ccea 
* Add `add_observer_metadata` `geo.name` to Quickstart

The observer location is very important in the Uptime app and the out-of-the-box machine learning job.

* Update getting-started.asciidoc

The instructions about editing heartbeat.yml were too wordy

* tighten it up!

Co-authored-by: DeDe Morton <dede.morton@elastic.co>

Co-authored-by: DeDe Morton <dede.morton@elastic.co>
@EamonnTP EamonnTP mentioned this pull request Oct 7, 2020
Merged
EamonnTP pushed a commit that referenced this pull request Oct 7, 2020
@DanRoscigno @dedemorton
Add add_observer_metadata geo.name to Quickstart (#21501) (#21639)
c1c6c7d 
* Add `add_observer_metadata` `geo.name` to Quickstart

The observer location is very important in the Uptime app and the out-of-the-box machine learning job.

* Update getting-started.asciidoc

The instructions about editing heartbeat.yml were too wordy

* tighten it up!

Co-authored-by: DeDe Morton <dede.morton@elastic.co>

Co-authored-by: DeDe Morton <dede.morton@elastic.co>

Co-authored-by: Dan Roscigno <dan@roscigno.com>
Co-authored-by: DeDe Morton <dede.morton@elastic.co>
EamonnTP pushed a commit that referenced this pull request Oct 7, 2020
@DanRoscigno @dedemorton
Add add_observer_metadata geo.name to Quickstart (#21501) (#21638)
e5e93b6 
* Add `add_observer_metadata` `geo.name` to Quickstart

The observer location is very important in the Uptime app and the out-of-the-box machine learning job.

* Update getting-started.asciidoc

The instructions about editing heartbeat.yml were too wordy

* tighten it up!

Co-authored-by: DeDe Morton <dede.morton@elastic.co>

Co-authored-by: DeDe Morton <dede.morton@elastic.co>

Co-authored-by: Dan Roscigno <dan@roscigno.com>
Co-authored-by: DeDe Morton <dede.morton@elastic.co>
v1v added a commit to v1v/beats that referenced this pull request Oct 8, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/2.0-skip-…
36ed51a 
…ci-build-label-support

* upstream/master: (60 commits)
  Skip publisher flaky tests (elastic#21657)
  backport: add 7.10 branch (elastic#21635)
  [CI: Packaging] fix: push ubi8 images too (elastic#21621)
  Docker build resiliance with a retry (elastic#21587)
  Fix flaky FSWatch/FSScanner tests (elastic#21625)
  chore: add versions 7.1x (elastic#21670)
  [Elastic Agent] Reload fleet.kibana.hosts from policy change (elastic#21599)
  Fix cyberark/corepas pipeline (elastic#21643)
  Add openstack ssl provider in add_cloud_metadata (elastic#21590)
  Add fips_enabled into all aws filesets (elastic#21626)
  [Filebeat S3] Change log.file.path to be nested object (elastic#21624)
  [CI] Change notification channel (elastic#21559)
  Add `add_observer_metadata` `geo.name` to Quickstart (elastic#21501)
  [E2E Tests] fix: set versions ony for PRs (elastic#21608)
  Fix badger build in 386 (elastic#21613)
  docs: Update timestamp.asciidoc (elastic#20395)
  Remove nil-zero metrics and linux-exclusive metrics from Metricbeat (elastic#21457)
  [Metricbeat] Use timestamp from CloudWatch for events (elastic#21498)
  [Filebeat][S3 Input] Add support for FIPS endpoints (elastic#21585)
  [Ingest Manager] Use new form of fleet API paths (elastic#21478)
  ...
v1v added a commit to v1v/beats that referenced this pull request Oct 8, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/windows-2…
b3b7cb1 
…012-2.0

* upstream/master: (110 commits)
  Skip publisher flaky tests (elastic#21657)
  backport: add 7.10 branch (elastic#21635)
  [CI: Packaging] fix: push ubi8 images too (elastic#21621)
  Docker build resiliance with a retry (elastic#21587)
  Fix flaky FSWatch/FSScanner tests (elastic#21625)
  chore: add versions 7.1x (elastic#21670)
  [Elastic Agent] Reload fleet.kibana.hosts from policy change (elastic#21599)
  Fix cyberark/corepas pipeline (elastic#21643)
  Add openstack ssl provider in add_cloud_metadata (elastic#21590)
  Add fips_enabled into all aws filesets (elastic#21626)
  [Filebeat S3] Change log.file.path to be nested object (elastic#21624)
  [CI] Change notification channel (elastic#21559)
  Add `add_observer_metadata` `geo.name` to Quickstart (elastic#21501)
  [E2E Tests] fix: set versions ony for PRs (elastic#21608)
  Fix badger build in 386 (elastic#21613)
  docs: Update timestamp.asciidoc (elastic#20395)
  Remove nil-zero metrics and linux-exclusive metrics from Metricbeat (elastic#21457)
  [Metricbeat] Use timestamp from CloudWatch for events (elastic#21498)
  [Filebeat][S3 Input] Add support for FIPS endpoints (elastic#21585)
  [Ingest Manager] Use new form of fleet API paths (elastic#21478)
  ...
EamonnTP pushed a commit that referenced this pull request Oct 14, 2020
@DanRoscigno @dedemorton
Add add_observer_metadata geo.name to Quickstart (#21501) (#21640)
5c85676 
* Add `add_observer_metadata` `geo.name` to Quickstart

The observer location is very important in the Uptime app and the out-of-the-box machine learning job.

* Update getting-started.asciidoc

The instructions about editing heartbeat.yml were too wordy

* tighten it up!

Co-authored-by: DeDe Morton <dede.morton@elastic.co>

Co-authored-by: DeDe Morton <dede.morton@elastic.co>

Co-authored-by: Dan Roscigno <dan@roscigno.com>
Co-authored-by: DeDe Morton <dede.morton@elastic.co>
andrewvc
andrewvc reviewed Oct 14, 2020
View reviewed changes
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Great, improvement!

@DanRoscigno
Copy link
Contributor Author

Thanks!

@DanRoscigno
Copy link
Contributor Author

@andrewvc can you walk me through updating the Kibana tutorial that covers installing Heartbeat to fix this there also? I found the .ts file in the Kibana repo, but am not sure if it is edited by hand or generated.

leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@DanRoscigno @dedemorton
Add add_observer_metadata geo.name to Quickstart (elastic#21501) (e…
ab87596 
…lastic#21638)

* Add `add_observer_metadata` `geo.name` to Quickstart

The observer location is very important in the Uptime app and the out-of-the-box machine learning job.

* Update getting-started.asciidoc

The instructions about editing heartbeat.yml were too wordy

* tighten it up!

Co-authored-by: DeDe Morton <dede.morton@elastic.co>

Co-authored-by: DeDe Morton <dede.morton@elastic.co>

Co-authored-by: Dan Roscigno <dan@roscigno.com>
Co-authored-by: DeDe Morton <dede.morton@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewvc andrewvc andrewvc left review comments

@dedemorton dedemorton dedemorton left review comments

@EamonnTP EamonnTP EamonnTP approved these changes

Assignees
No one assigned
Labels
docs Team:Docs Label for the Observability docs team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DanRoscigno @elasticmachine @EamonnTP @andrewvc @dedemorton @andresrc