Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix index out of range error when getting AWS account name #21101

Merged
merged 3 commits into from
Sep 17, 2020
Merged

Fix index out of range error when getting AWS account name #21101

merged 3 commits into from
Sep 17, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Sep 15, 2020

What does this PR do?

This PR is to fix panic in aws metricbeat module for by skipping running output.AccountAliases[0] after checking if the length of output.AccountAliasesis zero.

"panic": "runtime error: index out of range [0] with length 0"

Why is it important?

This error will happen when the user is trying to collect metrics with an account that does not have an account alias.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas

- [ ] I have made corresponding changes to the documentation
- [ ] I have made corresponding change to the default configuration files
- [ ] I have added tests that prove my fix is effective or that my feature works

  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 15, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Sep 15, 2020
@kaiyan-sheng kaiyan-sheng added bug needs_backport PR is waiting to be backported to other branches. Team:Platforms Label for the Integrations - Platforms team labels Sep 15, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 15, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 15, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21101 updated]

  • Start Time: 2020-09-17T14:24:53.661+0000

  • Duration: 50 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 845
Skipped 72
Total 917

@kaiyan-sheng kaiyan-sheng merged commit 568fbff into elastic:master Sep 17, 2020
@kaiyan-sheng kaiyan-sheng deleted the aws_bug branch September 17, 2020 15:42
@kaiyan-sheng kaiyan-sheng added v7.10.0 and removed needs_backport PR is waiting to be backported to other branches. labels Sep 17, 2020
kaiyan-sheng added a commit that referenced this pull request Sep 17, 2020
…AWS account name (#21144)

* Fix index out of range error when getting AWS account name (#21101)
(cherry picked from commit 568fbff)
kaiyan-sheng added a commit that referenced this pull request Sep 17, 2020
…AWS account name (#21143)

* Fix index out of range error when getting AWS account name (#21101)
(cherry picked from commit 568fbff)
v1v added a commit to v1v/beats that referenced this pull request Sep 18, 2020
…ne-2.0

* upstream/master:
  Add Cloud Foundry dashboards for metricbeat (elastic#21124)
  [Metricbeat][Kibana] Apply backoff when errored at getting usage stats (elastic#20772)
  Update input-log.asciidoc (elastic#20965) (elastic#21153)
  Remove redirects page (elastic#19574)
  [Ingest Manager] Fixed input types for filebeat (elastic#21131)
  docs: add beat specific install widget (elastic#21050)
  docs: link to APM privs for API keys (elastic#20911)
  Fix index out of range error when getting AWS account name (elastic#21101)
  Agent info docs and ci test pr (elastic#19805)
  Handling missing counters in application_pool metricset  (elastic#21071)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…etting AWS account name (elastic#21144)

* Fix index out of range error when getting AWS account name (elastic#21101)
(cherry picked from commit 749e0ea)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug review Team:Platforms Label for the Integrations - Platforms team v7.9.2 v7.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metricbeat + AWS Module: runtime error: index out of range [0] with length 0
3 participants