Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #20400 to 7.x: Flaky TestConfigurableService disable test (#20840) #21008

Merged
merged 1 commit into from
Sep 7, 2020
Merged

Cherry-pick #20400 to 7.x: Flaky TestConfigurableService disable test (#20840) #21008

merged 1 commit into from
Sep 7, 2020

Conversation

michalpristas
Copy link
Contributor

Cherry-pick of PR #20400 to 7.x branch. Original message:

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@ph @michalpristas
Flaky TestConfigurableService disable test (elastic#20840)
c7dcf46 
* Flaky TestConfigurableService disable test

* update skipnow to skipf

Co-authored-by: Michal Pristas <michal.pristas@gmail.com>
@michalpristas michalpristas self-assigned this Sep 7, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 7, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21008 opened]

  • Start Time: 2020-09-07T12:26:49.185+0000

  • Duration: 48 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 1574
Skipped 6
Total 1580

blakerouse
blakerouse approved these changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good.

@michalpristas michalpristas merged commit 8a4bcae into elastic:7.x Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

@ph ph Awaiting requested review from ph

Assignees

@michalpristas michalpristas

Labels
Agent backport review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michalpristas @elasticmachine @blakerouse @ph