Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fields.yml in azure module #20918

Merged
merged 23 commits into from
Sep 7, 2020
Merged

Update fields.yml in azure module #20918

merged 23 commits into from
Sep 7, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Sep 2, 2020 •
edited
Loading

What does this PR do?

Update fields.yml in azure module

Why is it important?

Update fields.yml in azure module

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 2, 2020
@narph narph self-assigned this Sep 2, 2020
@narph narph added [zube]: In Review Team:Platforms Label for the Integrations - Platforms team labels Sep 2, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 2, 2020
@narph narph added needs_backport PR is waiting to be backported to other branches. needs_team Indicates that the issue/PR needs a Team:* label labels Sep 2, 2020
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 2, 2020
@botelastic
Copy link

botelastic bot commented Sep 2, 2020

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 2, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20918 updated]

  • Start Time: 2020-09-04T14:11:08.418+0000

  • Duration: 64 min 0 sec

Test stats 🧪

Test Results
Failed 0
Passed 3622
Skipped 795
Total 4417

Steps errors

Expand to view the steps failures

  • Name: Install docker-compose 1.21.0

    • Description: .ci/scripts/install-docker-compose.sh

    • Duration: 1 min 33 sec

    • Start Time: 2020-09-04T14:38:09.737+0000

    • log

jsoriano
jsoriano previously approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a small suggestion but feel free to ignore it.

x-pack/metricbeat/module/azure/data.go Outdated Show resolved Hide resolved
@jsoriano jsoriano dismissed their stale review September 2, 2020 10:38

Thinking twice about implications of this change.

@narph narph changed the title Missing monitor object inside event azure data Update fields.yml in azure module Sep 2, 2020
jsoriano
jsoriano approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@narph narph merged commit 7ca9ebe into elastic:master Sep 7, 2020
@narph narph deleted the fix-event branch September 7, 2020 08:04
narph added a commit to narph/beats that referenced this pull request Sep 8, 2020
@narph
Update fields.yml in azure module (elastic#20918)
1ca175c 
* mofidy doc

* fix

* generate json

* changelog

* fields

* test

* update fields

(cherry picked from commit 7ca9ebe)
@narph narph mentioned this pull request Sep 8, 2020
Merged
6 tasks
narph added a commit that referenced this pull request Sep 15, 2020
@narph
Cherry-pick #20918 to 7.x: Update fields.yml in azure module (#21012)
0d6d95e 
* Update fields.yml in azure module (#20918)

* mofidy doc

* fix

* generate json

* changelog

* fields

* test

* update fields

(cherry picked from commit 7ca9ebe)

* fix changelog
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@narph @melchiormoulin
Update fields.yml in azure module (elastic#20918)
5d187c9 
* mofidy doc

* fix

* generate json

* changelog

* fields

* test

* update fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

Assignees

@narph narph

Labels
needs_backport PR is waiting to be backported to other branches. Team:Platforms Label for the Integrations - Platforms team [zube]: In Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narph @elasticmachine @jsoriano