Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #20440 to 7.9: [Filebeat][ATP Module]Setting user agent field required by the API #20443

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Cherry-pick #20440 to 7.9: [Filebeat][ATP Module]Setting user agent field required by the API #20443

merged 1 commit into from
Aug 5, 2020

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Aug 5, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #20440 to 7.9 branch. Original message:

What does this PR do?

Vendor modules are required to include a header for tracking purposes

Why is it important?

The header set is a requirement to use the ATP/MTP API.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@P1llus @adriansr
[Filebeat][ATP Module]Setting user agent field required by the API (e…
fb416b8 
…lastic#20440)

Setting user-agent field required by ATP API for monitoring purposes

(cherry picked from commit 6a9a20e)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 5, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 5, 2020
@adriansr adriansr added the review label Aug 5, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20443 opened]

  • Start Time: 2020-08-05T09:42:36.834+0000

  • Duration: 54 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 2434
Skipped 385
Total 2819

@adriansr adriansr merged commit 2ee3f83 into elastic:7.9 Aug 5, 2020
@adriansr
Copy link
Contributor Author

adriansr commented Aug 5, 2020

merged without approval due to urgency

@zube zube bot removed the [zube]: Done label Nov 3, 2020
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@adriansr @P1llus
[Filebeat][ATP Module]Setting user agent field required by the API (e…
9fb18a7 
…lastic#20440) (elastic#20443)

Setting user-agent field required by ATP API for monitoring purposes

(cherry picked from commit 63612b2)

Co-authored-by: Marius Iversen <pillus@chasenet.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adriansr @elasticmachine @P1llus