Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #20203 to 7.x: [Elastic Agent] Fix Windows powershell install service script #20251

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Cherry-pick #20203 to 7.x: [Elastic Agent] Fix Windows powershell install service script #20251

merged 1 commit into from
Jul 27, 2020

Conversation

blakerouse
Copy link
Contributor

Cherry-pick of PR #20203 to 7.x branch. Original message:

What does this PR do?

Fixes the Windows Elastic Agent service installation script to not mark the service as delayed start and to start the service.

Why is it important?

So Elastic Agent is started on the host as soon as possible and so the service is started.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@blakerouse
[Elastic Agent] Fix Windows powershell install service script (elasti…
adaffad 
…c#20203)

* Fix install service script.

* Add changelog.

* Register as a Windows service and fix issue with reader closer.

* Fix install service script.

* Add changelog.

(cherry picked from commit 3bacbfd)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 27, 2020
@blakerouse blakerouse self-assigned this Jul 27, 2020
michalpristas
michalpristas approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@blakerouse blakerouse merged commit 9807046 into elastic:7.x Jul 27, 2020
@blakerouse blakerouse deleted the backport_20203_7.x branch July 27, 2020 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalpristas michalpristas michalpristas approved these changes

Assignees

@blakerouse blakerouse

Labels
backport [zube]: In Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blakerouse @elasticmachine @michalpristas