Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #20207 to 7.x: [Filebeat] Ignore cylance.protect timestamps while testing #20216

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Cherry-pick #20207 to 7.x: [Filebeat] Ignore cylance.protect timestamps while testing #20216

merged 1 commit into from
Jul 23, 2020

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Jul 23, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #20207 to 7.x branch. Original message:

What does this PR do?

Ignore cylance.protect timestamps while testing. The logs may have syslog timestamps without years so the expected times can change.

Why is it important?

Fixes failing tests.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@andrewkroh @adriansr
[Filebeat] Ignore cylance.protect timestamps while testing (elastic#2…
96b02c1 
…0207)

* Ignore cylance.protect timestamps while testing

* Update generated

(cherry picked from commit ddf8c02)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 23, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 23, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20216 opened]

  • Start Time: 2020-07-23T18:36:27.609+0000

  • Duration: 58 min 37 sec

Test stats 🧪

Test Results
Failed 0
Passed 4265
Skipped 685
Total 4950

@adriansr adriansr merged commit 22d668c into elastic:7.x Jul 23, 2020
@zube zube bot removed the [zube]: Done label Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewstucki andrewstucki andrewstucki approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adriansr @elasticmachine @andrewstucki @andrewkroh