Cherry-pick #20054 to 7.x: [Filebeat] Chmod/Chown seccomp fix #20060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix fchmod syscall seccomp policy * Fix chown * Add changelog entry (cherry picked from commit bf56f6c)
botelastic
bot
added
needs_team
|
Pinging @elastic/siem (Team:SIEM) |
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
marc-gr
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #20054 to 7.x branch. Original message:
What does this PR do?
So, to support changing the file permissions dynamically for the filebeat unix socket input under seccomp, I had previously leveraged the fact that
chmodwas already in our whitelist--corresponding to this call--which was initially added in this commit, and also added a whitelist entry forchownto supportos.Chown.However, interestingly enough, on Linux systems
syscall.Chmodandsyscall.Chowndon't actually call thechownorchmodsyscalls at all (good naming convention, right?). Instead they usefchownatandfchmodat--see here.Currently filebeat is broken under seccomp without these additional entries.
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.