Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Favor direct mage invocation on CI #19960

Merged
merged 3 commits into from
Jul 17, 2020
Merged

[ci] Favor direct mage invocation on CI #19960

merged 3 commits into from
Jul 17, 2020

Commits on Jul 17, 2020

  1. Favor direct mage invocation on CI 

    This changes Jenkins and Travis to directly invoke mage where
possible instead of going through make. Some of the remaining
make don't yet have a mage equivalant (mainly crosscompile).

For Packetbeat this add Jenkins stages to test on darwin and Windows.

There were a few fixes I had to make related to these changes:

- Add some mage target dependencies to ensure fields and dashboards
  are ready when tests use them.
- Swap the order of the Go imports for dev-tools/mage/targets/integtest
  and unittest so that unit tests run before integ tests when running
  the 'mage test' target.
- chown the shared Python venv that is in the root of the repo after
  Dockerized integ tests exit to ensure there are no permissions issues
  caused by root owned files.
- I found a few Python string encoding issues that caused tests failures.
  I thought we fixed these during the Python 3 conversion, but something
  here exposed a few that we didn't address.

One thing of note that I did not correct. Journalbeat has system tests
but they are not executed. The existing/old Makefile has SYSTEM_TESTS=false
so they are not executed. So when I switched it to mage I left it as
'mage goUnitTest' to avoid the Python when failed when I tried it.
    @andrewkroh
    andrewkroh committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    cce8284 View commit details
    Browse the repository at this point in the history

  2. Undo removal of stress-tests stage

    @andrewkroh
    andrewkroh committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    2a5e669 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of github.com:elastic/beats into feature/jenkin… 

    …sfile-favor-mage
    @andrewkroh
    andrewkroh committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    77294d7 View commit details
    Browse the repository at this point in the history