Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #19603 to 7.x: Remove the downloadConfig and retryConfig from plugin/process.Application and plugin/service.Application. #19788

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

blakerouse
Copy link
Contributor

Cherry-pick of PR #19603 to 7.x branch. Original message:

What does this PR do?

Remove the downloadConfig and retryConfig from plugin/process.Application and plugin/service.Application.

Why is it important?

They are not used by either.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

…tion and plugin/service.Application. (elastic#19603)

* Remove the downloadConfig and retryConfig from plugin/process.Application and plugin/service.Application.

* Run mage fmt.

(cherry picked from commit fb53a8a)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 9, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 9, 2020
@blakerouse blakerouse self-assigned this Jul 9, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19788 opened]

  • Start Time: 2020-07-09T14:18:44.403+0000

  • Duration: 38 min 22 sec

Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blakerouse blakerouse merged commit 0ec8109 into elastic:7.x Jul 9, 2020
@blakerouse blakerouse deleted the backport_19603_7.x branch July 9, 2020 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants