Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] support windows-2012 #19773

Merged
merged 4 commits into from
Jul 13, 2020
Merged

[CI] support windows-2012 #19773

merged 4 commits into from
Jul 13, 2020

Conversation

v1v
Copy link
Member

@v1v v1v commented Jul 9, 2020

What does this PR do?

Add support for windows-2012 when running the tests in the CI Pipeline

Issues

@v1v v1v self-assigned this Jul 9, 2020
@v1v v1v added the automation label Jul 9, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 9, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 9, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Branch indexing]

  • Start Time: 2020-07-13T09:40:01.970+0000

  • Duration: 23 min 36 sec

v1v added 2 commits July 9, 2020 18:13
* upstream/master:
  Add `docker logs` support to the Elastic Log Driver (elastic#19531)
  [Elastic Agent] Fix saving of agent configuration on Windows to have proper ACLs (elastic#19793)
  Send the config revision down to the endpoint application. (elastic#19759)
  [Elastic Agent] Add support for multiple hosts in connection to kibana (elastic#19628)
  Remove the downloadConfig and retryConfig from plugin/process.Application and plugin/service.Application. (elastic#19603)
  Update go version to 1.14.4 (elastic#19753)
  ci: set builds as skipped when they do not match the trigger (elastic#19750)
  [Auditbeat] Fix up socket dataset runaway CPU usage (elastic#19764)
  Convert cloudfoundry input to v2 (elastic#19717)
* upstream/master:
  Add text & flattened fields in aws cloudtrail fileset (elastic#19121)
@andresrc andresrc added the Team:Automation Label for the Observability productivity team label Jul 13, 2020
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 13, 2020
@v1v v1v marked this pull request as ready for review July 13, 2020 11:40
@v1v v1v requested a review from a team as a code owner July 13, 2020 11:40
@v1v v1v requested review from ph, andrewkroh and a team and removed request for a team July 13, 2020 11:41
// NOTE: skip filebeat with windows-2016/2012-r2 since there are some test failures.
// See https://github.com/elastic/beats/issues/19787 https://github.com/elastic/beats/issues/19641
if (directory.equals('filebeat') && (label.equals('windows-2016') || label.equals('windows-2012-r2'))) {
log(level: 'WARN', text: "Skipped stage for the 'filebeat' with '${label}' as long as there are test failures to be analysed.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add the GH issue to the log? So that reading the CI logs will add that information

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I'll add it to the other PRs to enable Windows-7, 8, 10 as I need to rebase them too, does it sound good?

@v1v v1v merged commit 29b2d27 into elastic:master Jul 13, 2020
@v1v v1v deleted the feature/windows-2012 branch July 13, 2020 13:01
v1v added a commit to v1v/beats that referenced this pull request Jul 13, 2020
* upstream/master:
  [CI] support windows-2012 (elastic#19773)
  Do not update go.mod during packaging and testing (elastic#19823)
  Fix typo in ILM warning message (elastic#19819)
  [Winlogbeat] Remove beta tag from Powershell and Security modules (elastic#19817)
  feat: move the multibranch pipeline job to the beats repo (elastic#19698)
  Fix parsing timestamp in Filebeat registry tests (elastic#19796)
  Add text & flattened fields in aws cloudtrail fileset (elastic#19121)
v1v added a commit to v1v/beats that referenced this pull request Jul 14, 2020
* upstream/master: (25 commits)
  [Elastic Agent] Send checkin payload to Fleet (elastic#19857)
  [Ingest Manager] Fixed tests across agent elastic#19877
  [Ingest Manager] Fix serialization test  elastic#19876
  Fix service start type mapping in windows/service metricset (elastic#19551)
  ci: Change comment trigger detection method (elastic#19827)
  Add 21 autogenerated filesets from rsa2elk devices (elastic#19713)
  [Ingest Manager] Agent config cleanup (elastic#19848)
  libbeat/publisher/pipeline: fix data races (elastic#19821)
  Update monitoring-internal-collection.asciidoc (elastic#19422) (elastic#19697)
  [Elastic Agent] Trust exchange endpoint must bind to 127.0.0.1 (elastic#19861)
  Specify an ECS version in Auditbeat/Packetbeat/Winlogbeat (elastic#19159)
  Add azure billing metricset (elastic#19207)
  Add support for appinsights in the metricbeat azure module (elastic#18940)
  Add MySQL query metricset with lightweight module and SQL helper (elastic#18955)
  [Ingest Manager] Refuse invalid stream values in configuration (elastic#19587)
  Do not use vendor during integration tests (elastic#19839)
  LIBBEAT: Enhancement Convert dissected values from String to other basic data types and IP (elastic#18683)
  [Elastic Agent] Remove support for "logs" and only support logfile (elastic#19761)
  [CI] support windows-2012 (elastic#19773)
  Do not update go.mod during packaging and testing (elastic#19823)
  ...
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants